-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Laravel 11 #323
Support Laravel 11 #323
Conversation
… into feat/laravel11
I believe the main change in this project was the break in structure between carbon v2 and v3 *Some solutions I found:
To compare: |
hey @luanfreitasdev thanks for the PR! Would be great to have Log Viewer ready before L11 release. First of all, I think you may have misunderstood the intention of the Second, there were a few changes to the GitHub Actions workflow that I think were unnecessary :) And lastly, is there a resource on Laravel 11 and its changes/requirements already that I can double-check before merging the PR? |
@arukompas . I added the main corrections, removing the time zone when creating the Carbon object and adding it later using setTimezone. Github's actions have been rolled back. I didn't understand the last point. Did you mean do we have anything else to look forward to before Laravel 11? |
@luanfreitasdev great, thanks for the changes! Missed a few, noted above. As for the last part of what I meant. I don't know if there will be any breaking changes in Laravel 11. Are you aware of any? If so, where can I find them? If not then it's fine :) |
Hello, @arukompas !. I believe there is nothing significant in the case of the logs |
hey @luanfreitasdev , just one more issue mentioned above in the un-resolved comment :) We're almost there! |
Good reviewer 🔥 |
@luanfreitasdev big thanks, v3.4.0 tagged with support for Laravel 11! 🎉 All tests are passing everywhere. |
This PR adds the possibility of supporting Laravel 11 in the log viewer. I have some doubts regarding support so I opened PR with tests failing.
Is there a possibility that a change supported by Laravel 11 breaks the others (9, 10) and PHP 8.0, 8.1?
This Pull Request can be closed at any time by the log viewer team if it is not a priority or if it can be different or can also be worked on together