Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latest tag in value files #739

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

yongfengdu
Copy link
Collaborator

The latest tag is specified in the default values.yaml.
Add mm-embedding in valuefiles.yaml to track sync status with GenAIComps.

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

The latest tag is specified in the default values.yaml.
Add mm-embedding in valuefiles.yaml to track sync status with GenAIComps.

Signed-off-by: Dolpher Du <dolpher.du@intel.com>
@yongfengdu yongfengdu requested a review from lianhao as a code owner January 21, 2025 09:53
@yongfengdu
Copy link
Collaborator Author

The CI failure is due to lacking of image:
Failed to get image manifest ******:5000/opea/embedding-multimodal-bridgetower-gaudi:latest

@lianhao
Copy link
Collaborator

lianhao commented Jan 21, 2025

The failing is due to the missing image in gaudi CI environment

@lianhao lianhao added this to the v1.2 milestone Jan 21, 2025
@lianhao lianhao merged commit 9c808f8 into opea-project:main Jan 21, 2025
15 of 16 checks passed
@yongfengdu yongfengdu deleted the syncvalues branch January 22, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants