feat(condo): DOMA-10773 sendB2BAppPushMessage mutation and pass ticket created message #5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomerdvadcatpyat
temporarily deployed
to
internal
GitHub Actions
Inactive
nomerdvadcatpyat
temporarily deployed
to
internal
GitHub Actions
Inactive
nomerdvadcatpyat
temporarily deployed
to
internal
GitHub Actions
Inactive
nomerdvadcatpyat
temporarily deployed
to
internal
GitHub Actions
Inactive
nomerdvadcatpyat
force-pushed
the
feat/condo/DOMA-10773/sendB2BAppPushMessage
branch
from
d203f2b to
e98f206
Compare
nomerdvadcatpyat
temporarily deployed
to
internal
GitHub Actions
Inactive
Alllex202
reviewed
Dec 26, 2024
| }, | ||
|
|
||
| isBlacklisted: { | ||
| schemaDoc: 'Is message type in black list for this B2CApp', |
There was a problem hiding this comment.
Suggested change
| schemaDoc: 'Is message type in black list for this B2CApp', | |
| schemaDoc: 'Is message type in black list for this miniapp', |
Alllex202
reviewed
Dec 26, 2024
| b2cApp, | ||
| }) | ||
|
|
||
| const objs = await AppMessageSetting.getAll(admin, {}, { sortBy: ['updatedAt_DESC'] }) |
| b2cApp, | ||
| }) | ||
|
|
||
| const objs = await AppMessageSetting.getAll(support, {}, { sortBy: ['updatedAt_DESC'] }) |
Comment on lines
+178
to
+179
| test('can\'t read', async () => { | ||
| const objs = await AppMessageSetting.getAll(user, {}) |
There was a problem hiding this comment.
Better create a new object and filter by id
| }) | ||
|
|
||
| test('can update', async () => { | ||
| const [b2cApp] = await createTestB2CApp(admin) |
There was a problem hiding this comment.
You create a miniapp before each test, this line can be removed
Suggested change
| const [b2cApp] = await createTestB2CApp(admin) |
Comment on lines
+19
to
+27
| const userEmployees = await find('OrganizationEmployee', { | ||
| deletedAt: null, | ||
| organization: { deletedAt: null }, | ||
| role: { deletedAt: null }, | ||
| user: { id: user.id }, | ||
| isBlocked: false, | ||
| isRejected: false, | ||
| }) | ||
| const organizationIds = uniq(userEmployees.map(employee => employee.organization)) |
There was a problem hiding this comment.
why not use getEmployedOrganizationsByPermissions?
| to: { user: userFilter }, | ||
| organization: organizationFilter, | ||
| type, | ||
| lang: get(organization, ['country', 'locale'], conf.DEFAULT_LOCALE), |
There was a problem hiding this comment.
Should we use the organization locale or the user locale?
| organization: organizationFilter, | ||
| app: b2bAppFilter, | ||
| type, | ||
| meta, |
There was a problem hiding this comment.
How will a third party developer know what data needs to be passed to the meta? Is there any documentation?
Comment on lines
+77
to
+80
| mutations: [ | ||
| { | ||
| access: access.canSendB2BAppPushMessage, | ||
| schema: 'sendB2BAppPushMessage(data: SendB2BAppPushMessageInput!): SendB2BAppPushMessageOutput', |
There was a problem hiding this comment.
Could you add a few lines of documentation for this mutation?
Comment on lines
+192
to
+194
| await sendB2BAppPushMessageByTestClient(serviceUser, b2bApp, organization, staffClient.user, { | ||
| type: TICKET_CREATED_TYPE, | ||
| }) |
There was a problem hiding this comment.
TICKET_CREATED_TYPE for sendB2BAppPushMessage?
apps/condo/lang/es/es.json
Outdated
There was a problem hiding this comment.
For Spanish there shouldn't be all the templates, just the default?
nomerdvadcatpyat
temporarily deployed
to
internal
GitHub Actions
Inactive
…ET_CREATED_MESSAGE_TYPE for Message
…ing, rename app field to b2cApp, added b2bApp field
…PushMessageService, wrote tests
…create AppMessageSetting
nomerdvadcatpyat
force-pushed
the
feat/condo/DOMA-10773/sendB2BAppPushMessage
branch
from
cc3932b to
f176861
Compare
nomerdvadcatpyat
temporarily deployed
to
internal
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr:
sendB2BAppPushMessagemutation that allow to send messages from B2BApp. AddedcanExecuteSendB2BAppPushMessageandcanReadOrganizationEmployeestoB2BAppAccessRightSetB2CAppMessageSettingtoAppMessageSetting(DROP old table and CREATE new table for recreate all indexes, migrate data from old table to new). Renameappfield tob2cApp, addedb2bApptoAppMessageSetting.Added read accesses for staff user who is employee in organization with b2bApp from
AppMessageSetting.b2bAppB2B_APP_MESSAGE_PUSHandPASS_TICKET_CREATEDmessage typesAlso tasks related to this feature:
defaultContenttoMessageschema