Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve offerings #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve offerings #304

wants to merge 1 commit into from

Conversation

jelmerderonde
Copy link
Contributor

This PR improves the way the specification is written with regards to Offerings. It makes several changes:

  1. Update the OpenAPI version to 3.1.0 to allow the use of the const type.
  2. Make offeringType a constant set to program, course or component in the respective components.
  3. Restructure various files to simplify file organization.
  4. Reoorder attributes so the documentation renders the attributes in a more logical way.

Copy link
Contributor

@hamrt hamrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me I'm not sure how breaking this is though and if it should be part of a 5.0 patch round or more for an 5.1 or even 6.0

@jelmerderonde
Copy link
Contributor Author

@hamrt I don't think this is breaking or even changing the (intended) spec in any way. This PR is intended to merely write down the spec as we know it in a more precise way. Maybe we should meet to discuss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

2 participants