Added suffix for completion rules for Moodle 4.3+

open-lms-open-source · Nov 24, 2023 · 7835aa3 · 7835aa3
1 parent 5657d4d
commit 7835aa3
Showing 1 changed file with 32 additions and 17 deletions.
diff --git a/mod_form.php b/mod_form.php
@@ -742,30 +742,45 @@ function data_preprocessing(&$default_values) {
      * @return array Array of string IDs of added items, empty array if none
      */
     public function add_completion_rules() {
+        global $CFG;
+
         $mform =& $this->_form;
 
-        $group=array();
-        $group[] =& $mform->createElement('checkbox', 'completionpostsenabled', '', get_string('completionposts','hsuforum'));
-        $group[] =& $mform->createElement('text', 'completionposts', '', array('size'=>3));
-        $mform->setType('completionposts',PARAM_INT);
-        $mform->addGroup($group, 'completionpostsgroup', get_string('completionpostsgroup','hsuforum'), array(' '), false);
-        $mform->disabledIf('completionposts','completionpostsenabled','notchecked');
+        // Changes for Moodle 4.3 - MDL-78516.
+        if ($CFG->branch < 403) {
+            $suffix = '';
+        } else {
+            $suffix = $this->get_suffix();
+        }
 
         $group=array();
-        $group[] =& $mform->createElement('checkbox', 'completiondiscussionsenabled', '', get_string('completiondiscussions','hsuforum'));
-        $group[] =& $mform->createElement('text', 'completiondiscussions', '', array('size'=>3));
-        $mform->setType('completiondiscussions',PARAM_INT);
-        $mform->addGroup($group, 'completiondiscussionsgroup', get_string('completiondiscussionsgroup','hsuforum'), array(' '), false);
-        $mform->disabledIf('completiondiscussions','completiondiscussionsenabled','notchecked');
+        $group[] =& $mform->createElement('checkbox', 'completionpostsenabled' . $suffix, '',
+            get_string('completionposts','hsuforum'));
+        $group[] =& $mform->createElement('text', 'completionposts' . $suffix, '', array('size'=>3));
+        $mform->setType('completionposts' . $suffix,PARAM_INT);
+        $mform->addGroup($group, 'completionpostsgroup' . $suffix,
+            get_string('completionpostsgroup','hsuforum'), array(' '), false);
+        $mform->disabledIf('completionposts' . $suffix,'completionpostsenabled' . $suffix,'notchecked');
 
         $group=array();
-        $group[] =& $mform->createElement('checkbox', 'completionrepliesenabled', '', get_string('completionreplies','hsuforum'));
-        $group[] =& $mform->createElement('text', 'completionreplies', '', array('size'=>3));
-        $mform->setType('completionreplies',PARAM_INT);
-        $mform->addGroup($group, 'completionrepliesgroup', get_string('completionrepliesgroup','hsuforum'), array(' '), false);
-        $mform->disabledIf('completionreplies','completionrepliesenabled','notchecked');
+        $group[] =& $mform->createElement('checkbox', 'completiondiscussionsenabled' . $suffix, '',
+            get_string('completiondiscussions','hsuforum'));
+        $group[] =& $mform->createElement('text', 'completiondiscussions' . $suffix, '', array('size'=>3));
+        $mform->setType('completiondiscussions' . $suffix,PARAM_INT);
+        $mform->addGroup($group, 'completiondiscussionsgroup' . $suffix,
+            get_string('completiondiscussionsgroup','hsuforum'), array(' '), false);
+        $mform->disabledIf('completiondiscussions' . $suffix,'completiondiscussionsenabled' . $suffix,'notchecked');
 
-        return array('completiondiscussionsgroup','completionrepliesgroup','completionpostsgroup');
+        $group=array();
+        $group[] =& $mform->createElement('checkbox', 'completionrepliesenabled' . $suffix, '',
+            get_string('completionreplies','hsuforum'));
+        $group[] =& $mform->createElement('text', 'completionreplies' . $suffix, '', array('size'=>3));
+        $mform->setType('completionreplies' . $suffix,PARAM_INT);
+        $mform->addGroup($group, 'completionrepliesgroup' . $suffix,
+            get_string('completionrepliesgroup','hsuforum'), array(' '), false);
+        $mform->disabledIf('completionreplies' . $suffix,'completionrepliesenabled' . $suffix,'notchecked');
+
+        return ['completiondiscussionsgroup' . $suffix, 'completionrepliesgroup' . $suffix, 'completionpostsgroup' . $suffix];
     }
 
     function completion_rule_enabled($data) {