Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to build a project with PyTorch 2.0. #2553

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Added the ability to build a project with PyTorch 2.0. #2553

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccd1414
Added the ability to build a project with PyTorch 2.0.
Danil328 Nov 17, 2023
7770672
Lost the condition for the presence of nvcc
Danil328 Nov 17, 2023
e8a4497
Lost the condition for the presence of nvcc
Danil328 Nov 17, 2023
e6813e2
Add parse_version
Danil328 Nov 27, 2023
493b673
fix lint
irexyc Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import os

from pkg_resources import parse_version
from setuptools import find_packages, setup

EXT_TYPE = ''
try:
import torch
from torch.utils.cpp_extension import BuildExtension
cmd_class = {'build_ext': BuildExtension}
EXT_TYPE = 'torch'
Expand Down Expand Up @@ -139,7 +141,10 @@ def get_extensions():
# to compile those cpp files, so there is no need to add the
# argument
if platform.system() != 'Windows':
extra_compile_args['cxx'] = ['-std=c++14']
if parse_version(torch.__version__) <= parse_version('1.12.1'):
extra_compile_args['cxx'] = ['-std=c++14']
else:
extra_compile_args['cxx'] = ['-std=c++17']

include_dirs = []

Expand All @@ -159,7 +164,10 @@ def get_extensions():
# to compile those cpp files, so there is no need to add the
# argument
if 'nvcc' in extra_compile_args and platform.system() != 'Windows':
extra_compile_args['nvcc'] += ['-std=c++14']
if parse_version(torch.__version__) <= parse_version('1.12.1'):
extra_compile_args['nvcc'] += ['-std=c++14']
else:
extra_compile_args['nvcc'] += ['-std=c++17']

ext_ops = extension(
name=ext_name,
Expand Down
Loading