Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding beacons to book keeping to subscribe from ROS 2 #823

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Nov 1, 2023

What's new

Use open-rmf/rmf_internal_msgs@b59aa0b for beacon states.

beacons-2023-11-01_13.29.37.mp4

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
… API

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@xiyuoh
Copy link
Member

xiyuoh commented Nov 2, 2023

Tested with beacon adapter and works great!

@aaronchongth
Copy link
Member Author

awesome, ok I'm gonna merge this despite the test failures, since they are all regarding the import that our docker image building does not yet support

@aaronchongth aaronchongth merged commit 56316c4 into deploy/hammer Nov 2, 2023
1 of 3 checks passed
@aaronchongth aaronchongth deleted the feature/beacon-ros2 branch November 2, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants