Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ros2 delivery alerts #829

Merged
merged 10 commits into from
Nov 7, 2023

Conversation

aaronchongth
Copy link
Member

What's new

  • Use ROS 2 messages for delivery alerts request and responses
  • refactored beacon state and delivery alert events into rmf_events
  • removed unneeded queries for delivery alerts

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…ed models

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #829 (e721c2d) into deploy/hammer (fe0e808) will decrease coverage by 0.12%.
Report is 2 commits behind head on deploy/hammer.
The diff coverage is 0.00%.

❗ Current head e721c2d differs from pull request most recent head c51d695. Consider uploading reports for the commit c51d695 to get more accurate results

@@                Coverage Diff                @@
##           deploy/hammer     #829      +/-   ##
=================================================
- Coverage          49.35%   49.23%   -0.12%     
=================================================
  Files                285      285              
  Lines               7564     7561       -3     
  Branches            1050     1052       +2     
=================================================
- Hits                3733     3723      -10     
- Misses              3682     3689       +7     
  Partials             149      149              
Flag Coverage Δ
dashboard 15.00% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/api-server/api_server/models/__init__.py 100.00% <ø> (ø)
packages/api-server/api_server/rmf_io/__init__.py 100.00% <ø> (ø)
...ckages/api-server/api_server/rmf_io/book_keeper.py 97.24% <ø> (ø)
packages/api-server/api_server/rmf_io/events.py 100.00% <ø> (ø)
packages/api-server/api_server/routes/beacons.py 53.84% <ø> (+2.12%) ⬆️
...es/api-server/api_server/routes/delivery_alerts.py 40.47% <ø> (+0.47%) ⬆️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% <0.00%> (ø)
...ashboard/src/components/three-fiber/lift-three.tsx 0.00% <0.00%> (ø)
...shboard/src/components/three-fiber/robot-three.tsx 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit 655e37f into deploy/hammer Nov 7, 2023
2 of 4 checks passed
@aaronchongth aaronchongth deleted the feature/ros2-delivery-alerts branch November 7, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant