Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/roles and groups #836

Merged
merged 14 commits into from
Nov 21, 2023
Merged

Hammer/roles and groups #836

merged 14 commits into from
Nov 21, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Nov 20, 2023

What's new

  • Checking for superuser in realm_access.roles
  • Displaying logged in user as well as role (admin/user)

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 193 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (ad0b258) 47.92%.
Report is 8 commits behind head on deploy/hammer.

❗ Current head ad0b258 differs from pull request most recent head c852d76. Consider uploading reports for the commit c852d76 to get more accurate results

Files Patch % Lines
...es/api-server/api_server/models/delivery_alerts.py 14.28% 66 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 38 Missing ⚠️
packages/dashboard/src/components/map-app.tsx 0.00% 26 Missing ⚠️
...es/api-server/api_server/routes/delivery_alerts.py 26.66% 22 Missing ⚠️
packages/dashboard/src/components/app.tsx 0.00% 12 Missing ⚠️
...ashboard/src/components/three-fiber/lift-three.tsx 0.00% 10 Missing ⚠️
...shboard/src/components/three-fiber/robot-three.tsx 0.00% 10 Missing ⚠️
packages/api-server/api_server/authenticator.py 60.00% 4 Missing ⚠️
...ckages/api-server/api_server/rmf_io/book_keeper.py 75.00% 2 Missing ⚠️
packages/api-server/api_server/routes/beacons.py 33.33% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #836      +/-   ##
=================================================
- Coverage          49.35%   47.92%   -1.44%     
=================================================
  Files                285      287       +2     
  Lines               7564     7769     +205     
  Branches            1050     1071      +21     
=================================================
- Hits                3733     3723      -10     
- Misses              3682     3897     +215     
  Partials             149      149              
Flag Coverage Δ
dashboard 14.75% <2.04%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review November 20, 2023 14:45
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit e4ce10d into deploy/hammer Nov 21, 2023
4 of 5 checks passed
@aaronchongth aaronchongth deleted the hammer/roles-and-groups branch November 21, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant