Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obstructed and Cancelled delivery alert category with desired behaviors #839

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Nov 23, 2023

What's new

  • Works with open-rmf/rmf_internal_msgs@0997d89
  • Added obstructed and cancelled delivery alert category
  • For obstructed
    • no UI action needed, message will instruct users to move things out of the way of the robot
    • user can close the alert, but if the dashboard is refreshed, it will pop out again if the obstruction is still ongoing
    • once fleet adapter is able to continue, it will send another delivery alert request with the same IDs to update action to resume, the delivery alert will then stop showing up
  • For cancelled
    • we expect it to only have tier error
    • if however a tier warning comes through, it will be promoted to tier error with a console warning
    • no user interaction expected, they can only close it
delivery-alert-new-cat.mp4

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 275 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (e05e6ce) 47.73%.
Report is 17 commits behind head on deploy/hammer.

Files Patch % Lines
...es/api-server/api_server/models/delivery_alerts.py 12.94% 74 Missing ⚠️
packages/dashboard/src/components/map-app.tsx 0.00% 70 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 61 Missing ⚠️
...es/api-server/api_server/routes/delivery_alerts.py 26.66% 22 Missing ⚠️
...ashboard/src/components/three-fiber/lift-three.tsx 0.00% 10 Missing ⚠️
...shboard/src/components/three-fiber/robot-three.tsx 0.00% 10 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 5 Missing ⚠️
...oard/src/components/three-fiber/camera-control.tsx 0.00% 5 Missing ⚠️
packages/api-server/api_server/authenticator.py 60.00% 4 Missing ⚠️
...d/src/components/three-fiber/layers-controller.tsx 73.33% 3 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #839      +/-   ##
=================================================
- Coverage          49.35%   47.73%   -1.62%     
=================================================
  Files                285      287       +2     
  Lines               7564     7843     +279     
  Branches            1050     1112      +62     
=================================================
+ Hits                3733     3744      +11     
- Misses              3682     3950     +268     
  Partials             149      149              
Flag Coverage Δ
api-server 76.69% <29.53%> (-4.11%) ⬇️
dashboard 15.12% <12.37%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronchongth aaronchongth requested a review from xiyuoh November 23, 2023 07:06
@aaronchongth aaronchongth merged commit 844ec2b into deploy/hammer Nov 23, 2023
3 of 4 checks passed
@aaronchongth aaronchongth deleted the hammer/delivery-alert-new-cat branch November 23, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant