Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/save request (#842) #843

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Conversation

aaronchongth
Copy link
Member

  • New route for saving and getting successfully dispatched requests
  • Announce failed to dispatch instead of create task
  • Generate api-client
  • Use api task request instead of custom ttm pydantic model
  • Revert alert text change

(cherry picked from commit 52a7d14)

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 328 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (eff7f71) 47.56%.
Report is 22 commits behind head on deploy/hammer.

Files Patch % Lines
...es/api-server/api_server/models/delivery_alerts.py 12.94% 74 Missing ⚠️
packages/dashboard/src/components/map-app.tsx 0.00% 70 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 61 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 25 Missing ⚠️
...es/api-server/api_server/routes/delivery_alerts.py 26.66% 22 Missing ⚠️
...ckages/api-server/api_server/routes/tasks/tasks.py 36.36% 14 Missing ⚠️
...ashboard/src/components/three-fiber/lift-three.tsx 0.00% 10 Missing ⚠️
...shboard/src/components/three-fiber/robot-three.tsx 0.00% 10 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 7 Missing ⚠️
...ckages/api-server/api_server/repositories/tasks.py 57.14% 6 Missing ⚠️
... and 10 more
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #843      +/-   ##
=================================================
- Coverage          49.35%   47.56%   -1.79%     
=================================================
  Files                285      287       +2     
  Lines               7564     7909     +345     
  Branches            1050     1120      +70     
=================================================
+ Hits                3733     3762      +29     
- Misses              3682     3998     +316     
  Partials             149      149              
Flag Coverage Δ
api-server 76.34% <33.51%> (-4.46%) ⬇️
dashboard 14.93% <10.17%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* New route for saving and getting successfully dispatched requests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Announce failed to dispatch instead of create task

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Generate api-client

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use api task request instead of custom ttm pydantic model

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert alert text change

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit 52a7d14)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth force-pushed the hammer/save-task-request branch from 47afaec to 3a67ed6 Compare November 27, 2023 07:48
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I could not test, in the endpoint task/request, how do I send the ids, between commas?

Otherwise, it is perfect.
LGTM!

@aaronchongth
Copy link
Member Author

yup! you can just query separating the task ids with commas, I'll be merging it first, we can review it with the subsequent PR where I am using it

@aaronchongth aaronchongth merged commit 7663eac into deploy/hammer Nov 28, 2023
4 of 5 checks passed
@aaronchongth aaronchongth deleted the hammer/save-task-request branch November 28, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants