-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/save request (#842) #843
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## deploy/hammer #843 +/- ##
=================================================
- Coverage 49.35% 47.56% -1.79%
=================================================
Files 285 287 +2
Lines 7564 7909 +345
Branches 1050 1120 +70
=================================================
+ Hits 3733 3762 +29
- Misses 3682 3998 +316
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* New route for saving and getting successfully dispatched requests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Announce failed to dispatch instead of create task Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Generate api-client Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Use api task request instead of custom ttm pydantic model Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert alert text change Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> (cherry picked from commit 52a7d14) Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
47afaec
to
3a67ed6
Compare
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing I could not test, in the endpoint task/request, how do I send the ids, between commas?
Otherwise, it is perfect.
LGTM!
yup! you can just query separating the task ids with commas, I'll be merging it first, we can review it with the subsequent PR where I am using it |
(cherry picked from commit 52a7d14)
Self-checks