Hammer/task queue table #844

aaronchongth · 2023-11-27T09:38:04Z

What's new

Update task queue table

remove category column (users can check task summary for category or more information)
added pickup and destination column (filter and sorting will be in a subsequent PR)

The tasks shown below

RMF finishing task (this is different from our expected finishing task from deployment, so it is parsed as n/a)
patrol (only destination is parsed)
custom delivery (sequential), not dispatched as testing in simulation
delivery 1:1, not dispatched as testing in simulation

Self-checks

I have prototyped this new feature (if necessary) on Figma
I'm familiar with and follow this Typescript guideline
I added unit-tests for new components
I tried testing edge cases
I tested the behavior of the components that interact with the backend, with an e2e test

* New route for saving and getting successfully dispatched requests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Announce failed to dispatch instead of create task Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Generate api-client Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Use api task request instead of custom ttm pydantic model Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert alert text change Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> (cherry picked from commit 52a7d14) Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

codecov · 2023-11-28T02:54:30Z

Codecov Report

Attention: 422 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (f79560a) 47.24%.
Report is 24 commits behind head on deploy/hammer.

Files	Patch %	Lines
...es/api-server/api_server/models/delivery_alerts.py	12.94%	74 Missing ⚠️
packages/dashboard/src/components/map-app.tsx	0.00%	62 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx	0.00%	61 Missing ⚠️
packages/react-components/lib/tasks/utils.ts	4.76%	38 Missing and 2 partials ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx	0.00%	31 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx	0.00%	25 Missing ⚠️
...es/api-server/api_server/routes/delivery_alerts.py	26.66%	22 Missing ⚠️
...ckages/api-server/api_server/routes/tasks/tasks.py	36.36%	14 Missing ⚠️
...ashboard/src/components/three-fiber/lift-three.tsx	0.00%	10 Missing ⚠️
...shboard/src/components/three-fiber/robot-three.tsx	0.00%	9 Missing ⚠️
... and 18 more

Additional details and impacted files

@@                Coverage Diff                @@
##           deploy/hammer     #844      +/-   ##
=================================================
- Coverage          49.35%   47.24%   -2.11%     
=================================================
  Files                285      288       +3     
  Lines               7564     8005     +441     
  Branches            1050     1162     +112     
=================================================
+ Hits                3733     3782      +49     
- Misses              3682     4047     +365     
- Partials             149      176      +27

Flag	Coverage Δ
api-server	`76.34% <33.51%> (-4.46%)`	⬇️
dashboard	`15.03% <9.23%> (-0.04%)`	⬇️
react-components	`46.40% <19.31%> (-1.67%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

… now Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Angatupyry

This was awesome!

Thanks, Aaron!

LGTM!

Angatupyry · 2023-11-28T14:05:00Z

packages/dashboard/src/components/tasks/tasks-app.tsx

@@ -182,10 +183,25 @@ export const TasksApp = React.memo(
          const results = resp.data as TaskState[];
          const newTasks = results.slice(0, GET_LIMIT);

+          const taskIds: string[] = newTasks.map((task) => task.booking.id);


Maybe we can add a comment here explaining why we duplicated code and did not reuse the getAllTaskRequest function

aaronchongth · 2023-11-28T14:28:09Z

closing this in favor of #846

aaronchongth added 5 commits November 27, 2023 07:48

Regenerating api-client

1970313

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Passing requests into task data-grid component

ae49710

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Query multiple task requests

45e9421

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Merge branch 'hammer/save-task-request' into hammer/task-queue-table

8106ad6

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

aaronchongth changed the base branch from deploy/hammer to hammer/save-task-request November 27, 2023 09:38

aaronchongth added 3 commits November 27, 2023 09:53

Query task requests

77593e5

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Lint

eff7f71

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Merge branch 'hammer/save-task-request' into hammer/task-queue-table

b630b08

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Base automatically changed from hammer/save-task-request to deploy/hammer November 28, 2023 01:39

Parse and display pickup and dropoff

e9101f0

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

aaronchongth added 7 commits November 28, 2023 03:42

Parse automated charging task destination using task state

c4658f9

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Task queue table with category as well

d20a381

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Fix tests

e2f021c

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Export minimal with new columns

f31dce3

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Make requester, pickup and destination not sortable or filterable for…

b20c8c0

… now Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Reuse getAllTaskRequests

dfaf4e1

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Revert reuse as it requires adding dependencies

c05f02e

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

aaronchongth marked this pull request as ready for review November 28, 2023 07:40

aaronchongth requested a review from Angatupyry November 28, 2023 07:41

Revert category column, as filtering and sorting is convoluted for now

f79560a

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Angatupyry approved these changes Nov 28, 2023

View reviewed changes

aaronchongth changed the base branch from deploy/hammer to main November 28, 2023 14:10

aaronchongth changed the base branch from main to deploy/hammer November 28, 2023 14:10

aaronchongth mentioned this pull request Nov 28, 2023

Hammer/merge task queue table #846

Merged

5 tasks

aaronchongth closed this Nov 28, 2023

aaronchongth deleted the hammer/task-queue-table branch November 28, 2023 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hammer/task queue table #844

Hammer/task queue table #844

aaronchongth commented Nov 27, 2023 •

edited

Loading

codecov bot commented Nov 28, 2023 •

edited

Loading

Angatupyry left a comment

Angatupyry Nov 28, 2023

aaronchongth commented Nov 28, 2023

Hammer/task queue table #844

Hammer/task queue table #844

Conversation

aaronchongth commented Nov 27, 2023 • edited Loading

What's new

Self-checks

codecov bot commented Nov 28, 2023 • edited Loading

Codecov Report

Angatupyry left a comment

Choose a reason for hiding this comment

Angatupyry Nov 28, 2023

Choose a reason for hiding this comment

aaronchongth commented Nov 28, 2023

aaronchongth commented Nov 27, 2023 •

edited

Loading

codecov bot commented Nov 28, 2023 •

edited

Loading