Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side sort and filter pickup and destination #847

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

aaronchongth
Copy link
Member

What's new

  • adding pickup and destination to ttm task state model for filter and sorting purposes
  • saving task request saves pickup and destination information into ttm task state model
  • added pickup and destination to query
  • re-generated query api

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

… sorting purposes, generated query api

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 523 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (5cd3d10) 47.12%.
Report is 25 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 103 Missing ⚠️
...es/api-server/api_server/models/delivery_alerts.py 12.94% 74 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 61 Missing ⚠️
...ckages/api-server/api_server/repositories/tasks.py 37.31% 42 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 38 Missing and 2 partials ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 35 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 25 Missing ⚠️
...es/api-server/api_server/routes/delivery_alerts.py 26.66% 22 Missing ⚠️
...ckages/api-server/api_server/routes/tasks/tasks.py 38.70% 19 Missing ⚠️
...shboard/src/components/three-fiber/robot-three.tsx 0.00% 11 Missing ⚠️
... and 20 more
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #847      +/-   ##
=================================================
- Coverage          49.35%   47.12%   -2.23%     
=================================================
  Files                285      288       +3     
  Lines               7564     8081     +517     
  Branches            1050     1166     +116     
=================================================
+ Hits                3733     3808      +75     
- Misses              3682     4097     +415     
- Partials             149      176      +27     
Flag Coverage Δ
api-server 75.44% <34.23%> (-5.36%) ⬇️
dashboard 15.01% <7.77%> (-0.06%) ⬇️
react-components 46.40% <21.78%> (-1.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and is works as expected!

LGTM!

@aaronchongth aaronchongth merged commit d85661b into deploy/hammer Nov 29, 2023
5 of 6 checks passed
@aaronchongth aaronchongth deleted the hammer/filter-sort branch November 29, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants