Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/new on cancel #890

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Hammer/new on cancel #890

merged 5 commits into from
Jan 30, 2024

Conversation

aaronchongth
Copy link
Member

What's new

  • Updated task descriptions for delivery and custom delivery
  • Added tests to match json directly

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…ivery custom

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 866 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (96dbc1f) 27.05%.
Report is 56 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 171 Missing ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 17.56% 122 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 100 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 54 Missing and 6 partials ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 52 Missing ⚠️
packages/dashboard/src/components/door-summary.tsx 0.00% 51 Missing ⚠️
...shboard/src/components/tasks/task-cancellation.tsx 0.00% 48 Missing ⚠️
packages/dashboard/src/components/lift-summary.tsx 0.00% 47 Missing ⚠️
packages/dashboard/src/components/appbar.tsx 35.29% 22 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 20 Missing ⚠️
... and 26 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           deploy/hammer     #890       +/-   ##
==================================================
- Coverage          49.35%   27.05%   -22.31%     
==================================================
  Files                285      157      -128     
  Lines               7564     5242     -2322     
  Branches            1050     1337      +287     
==================================================
- Hits                3733     1418     -2315     
+ Misses              3682     3625       -57     
- Partials             149      199       +50     
Flag Coverage Δ
api-server ?
dashboard 13.84% <3.61%> (-1.23%) ⬇️
react-components 44.58% <20.93%> (-3.50%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronchongth aaronchongth merged commit 3acb520 into deploy/hammer Jan 30, 2024
3 checks passed
@aaronchongth aaronchongth deleted the hammer/new-on-cancel branch January 30, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant