Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating route for responding to delivery alert #919

Closed
wants to merge 1 commit into from

Conversation

aaronchongth
Copy link
Member

What's new

  • refactor route to respond to delivery alerts

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 46.77%. Comparing base (fe0e808) to head (c1124b2).
Report is 72 commits behind head on deploy/hammer.

Files Patch % Lines
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 3 Missing ⚠️
...es/api-server/api_server/routes/delivery_alerts.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #919      +/-   ##
=================================================
- Coverage          49.35%   46.77%   -2.58%     
=================================================
  Files                285      204      -81     
  Lines               7564     6283    -1281     
  Branches            1050      863     -187     
=================================================
- Hits                3733     2939     -794     
+ Misses              3682     3338     -344     
+ Partials             149        6     -143     
Flag Coverage Δ
api-server 77.26% <50.00%> (-3.54%) ⬇️
dashboard 13.73% <0.00%> (-1.34%) ⬇️
react-components ?
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronchongth
Copy link
Member Author

Closing as resolved due to mismatched version of dashboard and server

@aaronchongth aaronchongth deleted the hammer/delivery-alert-response branch June 26, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant