Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-server: first impl of rio #960

Merged
merged 5 commits into from
Jul 4, 2024
Merged

api-server: first impl of rio #960

merged 5 commits into from
Jul 4, 2024

Conversation

koonpeng
Copy link
Collaborator

What's new

A set of endpoints for RIO (Robot Interaction Objects), a simple system to represent generic "objects" which can be tracked by RMF. For now this is just endpoints to store and query RIO. There is no usage of RIO in RMF yet, this is just an initial data structure to facilitate future integrations.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

koonpeng added 3 commits June 24, 2024 09:38
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
@koonpeng koonpeng requested a review from aaronchongth June 24, 2024 10:03
koonpeng added 2 commits June 26, 2024 06:04
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this up so quickly! We will need this for the SCAS integration, could you have this ported to deploy/hammer-humble(edited) as well? I guess either target it from this PR or port it over

@aaronchongth aaronchongth merged commit 764c551 into main Jul 4, 2024
2 checks passed
@aaronchongth aaronchongth deleted the koonpeng/rio branch July 4, 2024 03:47
aaronchongth pushed a commit that referenced this pull request Jul 4, 2024
* first impl of rio

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* fix lint

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* cleanup

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* add option to reset app before each test

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* fix lint

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

---------

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
(cherry picked from commit 764c551)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth added a commit that referenced this pull request Jul 5, 2024
* api-server: first impl of rio (#960)

* first impl of rio

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* fix lint

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* cleanup

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* add option to reset app before each test

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* fix lint

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

---------

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
(cherry picked from commit 764c551)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fixed port to accommodate older pydantic version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Comment out test for deployment that uses older pydantic

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Co-authored-by: Teo Koon Peng <teokoonpeng@gmail.com>
aaronchongth pushed a commit that referenced this pull request Jul 21, 2024
* first impl of rio

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* fix lint

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* cleanup

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* add option to reset app before each test

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* fix lint

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

---------

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
(cherry picked from commit 764c551)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants