Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loadgenerator] start locust with host "0.0.0.0" (#1437) #1509

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

MoZhonghua
Copy link
Contributor

@MoZhonghua MoZhonghua commented Apr 8, 2024

starts locust with env LOCUST_WEB_HOST=0.0.0.0

fix #1437

@MoZhonghua MoZhonghua requested a review from a team April 8, 2024 09:01
Copy link

linux-foundation-easycla bot commented Apr 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: puckpuck / name: Pierre Tessier (b567f32)
  • ✅ login: MoZhonghua / name: Mo Zhonghua (5423d20)

@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Apr 8, 2024
@puckpuck
Copy link
Contributor

puckpuck commented Apr 9, 2024

Why is this change needed?

@MoZhonghua
Copy link
Contributor Author

MoZhonghua commented Apr 9, 2024

Why is this change needed?

locust fails to start if ipv6 is disabled. With this env, we force locust to bind ipv4 address.

fix this #1437

Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is fine, but we should be following the pattern for the other LOCUST_* environment variables, which is defining them all in the .env file, and referencing them from the 2 compose files.

SIMILAR to how we LOCUST_WEB_PORT and LOCUST_HOST defined.

@MoZhonghua
Copy link
Contributor Author

MoZhonghua commented Apr 11, 2024

LOCUST_WEB_PORT

This implementation is fine, but we should be following the pattern for the other LOCUST_* environment variables, which is defining them all in the .env file, and referencing them from the 2 compose files.

SIMILAR to how we LOCUST_WEB_PORT and LOCUST_HOST defined.

I Can't figure out how to change 'LOCUST_WEB_HOST' in .env file, it's already defined in .env as LOCUST_WEB_HOST=loadgenerator.

I guess LOCUST_WEB_HOST in .env is used by other service to get node name (or dns name? i don't known) of loadgenerator, not to tell locust to bind to this address.

So there are tow different things (in my guess):

  • how other service find address of loadgenerator
  • which ip address shoud loadgenerator bind

These two things just use same env name by coincidence.

@puckpuck
Copy link
Contributor

hmmm... I see now. We did some unfortunate things with the naming of environment variables used for the frontend-proxy.

Let's get this one approved and merged. I'll create a separate issue to track fixing the frontend-proxy.

@puckpuck puckpuck merged commit 103738b into open-telemetry:main Apr 12, 2024
27 checks passed
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadgenerator failed to start when ipv6 is disabled
3 participants