-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loadgenerator] start locust with host "0.0.0.0" (#1437) #1509
Conversation
Why is this change needed? |
locust fails to start if ipv6 is disabled. With this env, we force locust to bind ipv4 address. fix this #1437 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is fine, but we should be following the pattern for the other LOCUST_*
environment variables, which is defining them all in the .env file, and referencing them from the 2 compose files.
SIMILAR to how we LOCUST_WEB_PORT and LOCUST_HOST defined.
I Can't figure out how to change 'LOCUST_WEB_HOST' in .env file, it's already defined in I guess So there are tow different things (in my guess):
These two things just use same env name by coincidence. |
hmmm... I see now. We did some unfortunate things with the naming of environment variables used for the frontend-proxy. Let's get this one approved and merged. I'll create a separate issue to track fixing the frontend-proxy. |
open-telemetry#1509) Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
starts
locust
with envLOCUST_WEB_HOST=0.0.0.0
fix #1437