Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate protobuf code for TypeScript service - Frontend #1954

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Sozhan308
Copy link
Contributor

@Sozhan308 Sozhan308 commented Jan 25, 2025

Changes

Part of #1787 to generate profobuf files for all services.

This PR implements pre-generation of protobuf definitions for the frontend service

  1. Created a dedicated Dockerfile for protobuf generation

    • Added src/frontend/genproto/Dockerfile for handling proto generation
  2. Updated main frontend Dockerfile

    • Removed protobuf generation from build stage
    • Added pre-generated protos copy
    • Removed unnecessary protobuf dependencies from runner stage

Testing

  • Verified proto generation using docker-gen-proto.sh

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@Sozhan308 Sozhan308 requested a review from a team as a code owner January 25, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant