Remove CPU limits from opentelementry-operator contianers

open-telemetry · Jan 22, 2025 · d713895 · d713895
1 parent dbddf84
commit d713895
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 17 deletions.
diff --git a/charts/opentelemetry-operator/Chart.yaml b/charts/opentelemetry-operator/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: opentelemetry-operator
-version: 0.78.2
+version: 0.79.0
 description: OpenTelemetry Operator Helm chart for Kubernetes
 type: application
 home: https://opentelemetry.io/

diff --git a/charts/opentelemetry-operator/UPGRADING.md b/charts/opentelemetry-operator/UPGRADING.md
@@ -1,5 +1,29 @@
 # Upgrade guidelines
 
+## 0.78.2 to 0.79.0
+
+Prior to 0.79.0, this chart included resource requests and limits for the OpenTelemetry Operator manager pod. These values were set to `100m` and `128Mi` respectively. In 0.78.0, these values have been removed from the chart. If you were relying on these values, you can set them in your `values.yaml` file. For example:
+
+```yaml
+manager:
+  resources:
+    limits:
+      cpu: 100m
+      memory: 128Mi
+    requests:
+      cpu: 100m
+      memory: 64Mi
+
+kubeRBACProxy:
+  resources:
+    limits:
+      cpu: 500m
+      memory: 128Mi
+    requests:
+      cpu: 5m
+      memory: 64Mi
+```
+
 ## 0.74.0 to 0.74.1
 
 Prior to 0.72.1, feature gates could be enabled via the `manager.featureGates` property. As feature gates may require extra configuration to work properly, e.g. deploying extra permissions on the ClusterRole, the chart has been updated to make use of the `manager.featureGatesMap` property which allows the chart to smartly configure feature gates. If the `manager.featureGatesMap` property is set, the old `manager.featureGates` property will be ignored.

diff --git a/charts/opentelemetry-operator/templates/NOTES.txt b/charts/opentelemetry-operator/templates/NOTES.txt
@@ -8,6 +8,10 @@
 The 'manager.featureGates' value is deprecated. Please migrate to use the 'manager.featureGatesMap' value.
 {{ end }}
 
+{{- if not .Values.resources }}
+[WARNING] No resource limits or requests were set. Consider setter resource requests and limits for your collector(s) via the `resources` field.
+{{ end }}
+
 {{ $.Chart.Name }} has been installed. Check its status by running:
   kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/name={{ $.Release.Name }}"
 

diff --git a/charts/opentelemetry-operator/values.yaml b/charts/opentelemetry-operator/values.yaml
@@ -90,20 +90,23 @@ manager:
     metricsPort: 8080
     webhookPort: 9443
     healthzPort: 8081
-  resources:
-    limits:
-      cpu: 100m
-      memory: 128Mi
-      # ephemeral-storage: 50Mi
-    requests:
-      cpu: 100m
-      memory: 64Mi
-      # ephemeral-storage: 50Mi
+  resources: {}
+  # resources:
+  #   limits:
+  #     cpu: 100m
+  #     memory: 128Mi
+  #     ephemeral-storage: 50Mi
+  #   requests:
+  #     cpu: 100m
+  #     memory: 64Mi
+  #     ephemeral-storage: 50Mi
+
   ## Adds additional environment variables. This property will be deprecated. Please use extraEnvs instead.
   ## e.g ENV_VAR: env_value
   env:
     ENABLE_WEBHOOKS: "true"
 
+
   # Extra definitions of environment variables.
   extraEnvs: []
     # - name: GOMEMLIMIT
@@ -216,13 +219,14 @@ kubeRBACProxy:
     tag: v0.18.1
   ports:
     proxyPort: 8443
-  resources:
-    limits:
-      cpu: 500m
-      memory: 128Mi
-    requests:
-      cpu: 5m
-      memory: 64Mi
+  resources: {}
+  # resources:
+  #   limits:
+  #     cpu: 500m
+  #     memory: 128Mi
+  #   requests:
+  #     cpu: 5m
+  #     memory: 64Mi
 
   ## List of additional cli arguments to configure the kube-rbac-proxy
   ## for example: --tls-cipher-suites, --tls-min-version, etc.