[demo] add imageprovider #1130
[demo] add imageprovider #1130
Conversation
|
Because this is adding a new service that has not yet been released, we need to wait for the next demo release before merging this. |
| securityContext: | ||
| runAsUser: 101 # nginx | ||
| runAsGroup: 101 | ||
| runAsNonRoot: true | ||
|
|
There was a problem hiding this comment.
is this working for you? it is triggering /bin/sh: 1: cannot create /etc/nginx/nginx.conf: Permission denied here
| - name: IMAGE_PROVIDER_PORT | ||
| value: "8081" | ||
| - name: IMAGE_PROVIDER_HOST | ||
| value: '{{ include "otel-demo.name" . }}-IMAGE_PROVIDER_PORT' |
There was a problem hiding this comment.
| value: '{{ include "otel-demo.name" . }}-IMAGE_PROVIDER_PORT' | |
| value: '{{ include "otel-demo.name" . }}-imageprovider' |
|
IMAGE_PROVIDER_PORT is already required in https://github.com/grafana/opentelemetry-demo/blob/06023dd91e02d2da7818137b1e09eadd1d86228b/src/frontendproxy/envoy.tmpl.yaml#L109-L110 - so helm chart 0.30.2 is broken |
Actually not @zeitlinger. |
I'm using a fork of the otel demo - and did a rebase before I encountered the problem. Maybe that was the root cause. |
…mageprovider # Conflicts: # charts/opentelemetry-demo/Chart.yaml # charts/opentelemetry-demo/examples/bring-your-own-observability/rendered/component.yaml # charts/opentelemetry-demo/examples/bring-your-own-observability/rendered/flagd-config.yaml # charts/opentelemetry-demo/examples/bring-your-own-observability/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/component.yaml # charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/flagd-config.yaml # charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/custom-environment-variables/rendered/component.yaml # charts/opentelemetry-demo/examples/custom-environment-variables/rendered/flagd-config.yaml # charts/opentelemetry-demo/examples/custom-environment-variables/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/custom-environment-variables/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/default/rendered/component.yaml # charts/opentelemetry-demo/examples/default/rendered/flagd-config.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/default/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/component.yaml # charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/flagd-config.yaml # charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/component.yaml # charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/flagd-config.yaml # charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/serviceaccount.yaml
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Has the demo had a release yet with the new service? |
|
No afaict, 1.9.0 was released 2 days before open-telemetry/opentelemetry-demo#1462 was merged |
Correct, imageprovider was not released yet. |
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
|
@klucsik I needed to get this running for my team's demo efforts. I figured out why the nginx pod wasn't starting (securityContext) and updated the frontendproxy config. I pushed the changes to your branch. I will push to get a demo 1.10.x release done, so we can merge this. |
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
With #1220 getting merged, this is no longer needed. |
Update demo chart to include open-telemetry/opentelemetry-demo#1462