Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninstall hook for the kube-stack chart #1305

Merged
merged 28 commits into from
Aug 20, 2024

Conversation

jaronoff97
Copy link
Contributor

@jaronoff97 jaronoff97 commented Aug 13, 2024

This adds an uninstall hook which makes sure that we get rid of the CRs before we uninstall the operator. Closes #1300

@jaronoff97 jaronoff97 requested a review from a team August 13, 2024 19:59
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

charts/opentelemetry-kube-stack/values.yaml Outdated Show resolved Hide resolved
@TylerHelmuth
Copy link
Member

@jaronoff97 can we reuse the prom live stack charts solution, whatever it is?

@TylerHelmuth TylerHelmuth merged commit 96fc70a into open-telemetry:main Aug 20, 2024
3 checks passed
@jaronoff97 jaronoff97 deleted the fix-uninstall-kos branch August 20, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opentelemetry-kube-stack] Chart testing doesn't work when the operator is enabled.
2 participants