Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[opentelemetry-kube-stack] add persistentvolumeclaims to ClusterRole #1446

Merged
merged 9 commits into from
Dec 16, 2024
Merged

fix[opentelemetry-kube-stack] add persistentvolumeclaims to ClusterRole #1446

merged 9 commits into from
Dec 16, 2024

Conversation

genadipost
Copy link
Contributor

fixes #1444

@genadipost genadipost requested review from jaronoff97 and a team as code owners December 5, 2024 13:23
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 5, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@genadipost genadipost force-pushed the fix/opentelemetry-kube-stack-add-clusterrole-persistentvolumeclaims branch from 4f03a52 to 5cab8df Compare December 5, 2024 13:25
jaronoff97
jaronoff97 reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution! can you bump the patch version of the chart and run make generate-examples CHARTS=opentelemetry-kube-stack when you get a chance?

@genadipost
Copy link
Contributor Author

@jaronoff97 There is some tool or make command to perform the bump?

@jaronoff97
Copy link
Contributor

Yep, there's a makefile at the root of the repo. I posted the command above :)

@genadipost genadipost force-pushed the fix/opentelemetry-kube-stack-add-clusterrole-persistentvolumeclaims branch from 430e9f7 to f188700 Compare December 6, 2024 07:49
@genadipost
Copy link
Contributor Author

@jaronoff97 I have run make generate-examples CHARTS=opentelemetry-kube-stack

@povilasv
Copy link
Contributor

povilasv commented Dec 6, 2024

@genadipost you need to bump the patch version and then run make generate-examples CHARTS=opentelemetry-kube-stack

@cabrinha
Copy link
Contributor

cabrinha commented Dec 6, 2024

You should also add persistentvolumes as well

@genadipost
Copy link
Contributor Author

You should also add persistentvolumes as well

I can make another pull request

@genadipost
Copy link
Contributor Author

@povilasv @jaronoff97 I have bumped make generate-examples CHARTS=opentelemetry-kube-stack

@genadipost
Copy link
Contributor Author

genadipost commented Dec 10, 2024 •
edited
Loading

@genadipost you need to bump the patch version and then run make generate-examples CHARTS=opentelemetry-kube-stack

@povilasv
Done :)

@genadipost genadipost force-pushed the fix/opentelemetry-kube-stack-add-clusterrole-persistentvolumeclaims branch from 084ed41 to f885e77 Compare December 11, 2024 09:28
@jaronoff97
Copy link
Contributor

@genadipost when you get a chance, could you sign the CLA please?

@genadipost genadipost force-pushed the fix/opentelemetry-kube-stack-add-clusterrole-persistentvolumeclaims branch from 42247d7 to 538cddc Compare December 13, 2024 16:11
@genadipost
Copy link
Contributor Author

@genadipost when you get a chance, could you sign the CLA please?

@jaronoff97 Just did.

@TylerHelmuth TylerHelmuth merged commit ffcb619 into open-telemetry:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@povilasv povilasv povilasv approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@jaronoff97 jaronoff97 jaronoff97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[opentelemetry-kube-stack] Missing permissions in ClusterRole for PersistentVolumes
5 participants
@genadipost @jaronoff97 @povilasv @cabrinha @TylerHelmuth