Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry-kube-stack] Add the helper for servicemonitor.scrapeLi… #1455

Merged
merged 3 commits into from
Dec 12, 2024
Merged

[opentelemetry-kube-stack] Add the helper for servicemonitor.scrapeLi… #1455

merged 3 commits into from
Dec 12, 2024

Conversation

cabrinha
Copy link
Contributor

@cabrinha cabrinha commented Dec 6, 2024 •
edited
Loading

Solves #1453

@cabrinha cabrinha requested review from jaronoff97 and a team as code owners December 6, 2024 17:32
jaronoff97
jaronoff97 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me! thank you 🙇 I'm wondering if we should also change an example to enable the kubelet so we can see the effect?

@cabrinha
Copy link
Contributor Author

cabrinha commented Dec 6, 2024

this looks good to me! thank you 🙇 I'm wondering if we should also change an example to enable the kubelet so we can see the effect?

I think they're all already enabled: https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-kube-stack/examples/prometheus-otel/values.yaml#L51-L70

@cabrinha cabrinha force-pushed the otel-kube-stack-helpers-scrapelimits branch 3 times, most recently from ae1f1c5 to 919ea70 Compare December 11, 2024 21:03
@cabrinha cabrinha force-pushed the otel-kube-stack-helpers-scrapelimits branch from 408600d to 21c127e Compare December 11, 2024 21:06
@TylerHelmuth TylerHelmuth merged commit a836da3 into open-telemetry:main Dec 12, 2024
3 checks passed
@jaronoff97
Copy link
Contributor

@cabrinha thank you very much for your contribution! 🙇

jtyr pushed a commit to jtyr/opentelemetry-helm-charts that referenced this pull request Dec 23, 2024
@cabrinha @jtyr
[opentelemetry-kube-stack] Add the helper for servicemonitor.scrapeLi… (
06bfb9f 
open-telemetry#1455)

* [opentelemetry-kube-stack] Add the helper for servicemonitor.scrapeLimits

* naming

* version bump, make gen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@jaronoff97 jaronoff97 jaronoff97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cabrinha @jaronoff97 @TylerHelmuth