squash: use compatible? predicate

open-telemetry · Jan 7, 2025 · 8b57d6a · 8b57d6a
1 parent f5408aa
commit 8b57d6a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/instrumentation/rdkafka/test/opentelemetry/instrumentation/rdkafka/instrumentation_test.rb b/instrumentation/rdkafka/test/opentelemetry/instrumentation/rdkafka/instrumentation_test.rb
@@ -22,6 +22,7 @@
 
   describe '#install' do
     it 'accepts argument' do
+      skip "#{Rdkafka::VERSION} is not supported" unless instrumentation.compatible?
       _(instrumentation.install({})).must_equal(true)
       instrumentation.instance_variable_set(:@installed, false)
     end

diff --git a/instrumentation/rdkafka/test/opentelemetry/instrumentation/rdkafka/patches/consumer_test.rb b/instrumentation/rdkafka/test/opentelemetry/instrumentation/rdkafka/patches/consumer_test.rb
@@ -33,7 +33,7 @@
 
     describe '#each' do
       it 'traces each call' do
-        skip "#{Rdkafka::VERSION} is not supported" unless instrumentation.installed?
+        skip "#{Rdkafka::VERSION} is not supported" unless instrumentation.compatible?
 
         rand_hash = SecureRandom.hex(10)
         topic_name = "consumer-patch-trace-#{rand_hash}"
@@ -114,7 +114,7 @@
       end
 
       it 'encodes messages keys depending on input format' do
-        skip "#{Rdkafka::VERSION} is not supported" unless instrumentation.installed?
+        skip "#{Rdkafka::VERSION} is not supported" unless instrumentation.compatible?
 
         rand_hash = SecureRandom.hex(10)
         topic_name = "consumer-patch-trace-#{rand_hash}"
@@ -168,7 +168,7 @@
 
     describe '#each_batch' do
       it 'traces each_batch call' do
-        skip "#{Rdkafka::VERSION} is not supported" unless instrumentation.installed?
+        skip "#{Rdkafka::VERSION} is not supported" unless instrumentation.compatible?
 
         rand_hash = SecureRandom.hex(10)
         topic_name = "consumer-patch-batch-trace-#{rand_hash}"

diff --git a/instrumentation/rdkafka/test/opentelemetry/instrumentation/rdkafka/patches/producer_test.rb b/instrumentation/rdkafka/test/opentelemetry/instrumentation/rdkafka/patches/producer_test.rb
@@ -32,7 +32,7 @@
 
     describe 'tracing' do
       it 'traces sync produce calls' do
-        skip "#{Rdkafka::VERSION} is not supported" unless instrumentation.installed?
+        skip "#{Rdkafka::VERSION} is not supported" unless instrumentation.compatible?
         topic_name = 'producer-patch-trace'
         config = { 'bootstrap.servers': "#{host}:#{port}" }