release: Release 4 gems #1161
Closed
release: Release 4 gems #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* opentelemetry-helpers-sql-obfuscation 0.2.0 (was 0.1.1) * opentelemetry-instrumentation-pg 0.29.0 (was 0.28.0) * opentelemetry-instrumentation-mysql2 0.28.0 (was 0.27.2) * opentelemetry-instrumentation-trilogy 0.60.0 (was 0.59.3)
github-actions
bot
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle and
xuan-cao-swi
as code owners
Comment on lines
+5
to
+7
| * BREAKING CHANGE: Return message when sql is over the obfuscation limit | ||
|
|
||
| * FIXED: Return message when sql is over the obfuscation limit |
There was a problem hiding this comment.
@arielvalentin - Is this too wordy for a changelog entry? I have another option that's a little more concise in another comment below. I think these should be edited regardless, since the same message is listed twice.
Whatever we pick, I'll apply to the other changelogs.
Suggested change
| * BREAKING CHANGE: Return message when sql is over the obfuscation limit | |
| * FIXED: Return message when sql is over the obfuscation limit | |
| * BREAKING CHANGE: Return a message when sql is over the obfuscation limit. Fixes a bug that sent un-obfuscated statements when sql was over the obfuscation limit and the statement had prepended comments. |
Comment on lines
+5
to
+7
| * BREAKING CHANGE: Return message when sql is over the obfuscation limit | ||
|
|
||
| * FIXED: Return message when sql is over the obfuscation limit |
There was a problem hiding this comment.
Suggested change
| * BREAKING CHANGE: Return message when sql is over the obfuscation limit | |
| * FIXED: Return message when sql is over the obfuscation limit | |
| * BREAKING CHANGE: Return message when sql is over the obfuscation limit | |
| * FIXED: SQL statements with prepended comments that exceeded the obfuscation limit would be sent unsanitized |
|
Closing, we need to update |
|
Release PR closed without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request prepares new gem releases for the following gems:
For each gem, this pull request modifies the gem version and provides an initial changelog entry based on conventional commit messages. You can edit these changes before merging, to release a different version or to alter the changelog text.
The generated changelog entries have been copied below:
opentelemetry-helpers-sql-obfuscation
v0.2.0 / 2024-09-10
BREAKING CHANGE: Return message when sql is over the obfuscation limit
FIXED: Return message when sql is over the obfuscation limit
opentelemetry-instrumentation-pg
v0.29.0 / 2024-09-10
BREAKING CHANGE: Return message when sql is over the obfuscation limit
FIXED: Return message when sql is over the obfuscation limit
opentelemetry-instrumentation-mysql2
v0.28.0 / 2024-09-10
BREAKING CHANGE: Return message when sql is over the obfuscation limit
FIXED: Return message when sql is over the obfuscation limit
opentelemetry-instrumentation-trilogy
v0.60.0 / 2024-09-10
BREAKING CHANGE: Return message when sql is over the obfuscation limit
FIXED: Return message when sql is over the obfuscation limit