Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add existence requirement #1014

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Add existence requirement #1014

merged 4 commits into from
Jan 9, 2025

Conversation

zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented Jan 9, 2025

Add ExistenceRequirement parameter to transfer/withdraw of MultiCurrency and BasicCurrency traits

@zjb0807 zjb0807 force-pushed the add-existence-requirement branch from ce76f2e to 07ad5c4 Compare January 9, 2025 03:20
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 59.57447% with 19 lines in your changes missing coverage. Please review.

Project coverage is 65.40%. Comparing base (286c731) to head (25f5a0a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
currencies/src/lib.rs 53.57% 13 Missing ⚠️
xcm-support/src/currency_adapter.rs 37.50% 5 Missing ⚠️
payments/src/lib.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   65.63%   65.40%   -0.23%     
==========================================
  Files          49       49              
  Lines        3704     3726      +22     
==========================================
+ Hits         2431     2437       +6     
- Misses       1273     1289      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjb0807 zjb0807 requested a review from xlc January 9, 2025 05:33
@zjb0807 zjb0807 marked this pull request as ready for review January 9, 2025 05:33
@zjb0807 zjb0807 merged commit 8285019 into master Jan 9, 2025
3 of 5 checks passed
@zjb0807 zjb0807 deleted the add-existence-requirement branch January 9, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants