-
Notifications
You must be signed in to change notification settings - Fork 381
Add document for SVC API #1039
base: master
Are you sure you want to change the base?
Add document for SVC API #1039
Conversation
doc/Client-Portal Protocol.md
Outdated
@@ -452,6 +454,10 @@ A publication can send either media or data, but a QUIC *transport* channel can | |||
mid: string(MID), | |||
from: string(TrackID) | string(StreamID), | |||
parameters: object(VideoParametersSpecification) | undefined, | |||
preferredLayers: { // Used to force layers for SVC stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we move this to parameters above? And the same shall be shared by subscription control singaling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My consideration is that the preferredLayers
may have conflict with parameters.resolution
or parameters.framerate
. For example, spatial layer 0 and resolution 720p may not align. Placing it outside parameters
can mean that it will override parameters
.
Besides, I have no idea about describing the parameters of an SVC stream yet. Because an SVC stream may have multiple resolutions. I'll use highest layers for parameters so far.
doc/servermd/RESTAPI.md
Outdated
@@ -131,6 +131,7 @@ Data Model:<br> | |||
transcoding: object(Transcoding), // the transcoding control | |||
notifying: object(Notifying), // notification control | |||
selectActiveAudio: boolean, // select 3 most active audio streams for the room | |||
senderBandwidthEstimation: boolean, // enable send side bandwidth estimation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be part of webrtc agent configuration instead of room configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion, ok to put this as part of room configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change its name to webrtcSenderSideBandwidthEstimation
? This configuration doesn't work for WebTransport connections.
No description provided.