Parallel JSON #1475
Merged
Parallel JSON #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
franzpoeschel
force-pushed
the
parallel-json
branch
2 times, most recently
from
1d8dbdb to
c42b8db
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
2 times, most recently
from
926c146 to
c1d9bb3
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
from
c1d9bb3 to
ea5aad3
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
from
ea5aad3 to
8d61c89
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
from
8d61c89 to
8153856
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
2 times, most recently
from
334bda1 to
ea497a0
Compare
| @@ -1269,40 +1339,141 @@ | |||
| return (*obtainJsonContents(file))[filePosition->id]; | |||
| } | |||
|
|
|||
| void JSONIOHandlerImpl::putJsonContents( | |||
| auto JSONIOHandlerImpl::putJsonContents( | |||
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
franzpoeschel
force-pushed
the
parallel-json
branch
2 times, most recently
from
308b6a1 to
8e7953c
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
3 times, most recently
from
fbb3ea5 to
38fd114
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
from
38fd114 to
369671e
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
2 times, most recently
from
a564618 to
9f0bb83
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
from
9f0bb83 to
66d05b1
Compare
franzpoeschel
force-pushed
the
parallel-json
branch
from
66d05b1 to
b92b9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1472
TODO:
Idea: When using in parallel, just create files
simData.json.parallel/rank_0.json, simData.json.parallel/rank_1.json, ...and so on. No direct support for reading, users need to either manually pick one of the JSON files or find some adequate tooling for merging them.