Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake minimum required #1558

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

titoiride
Copy link
Contributor

In this PR we update the cmake minimum required version for three packages that used cmake < 3.5.
This generated a cmake warning for new versions of cmake

Compatibility with CMake < 3.5 will be removed from a future version of CMake.

This PR closes #1557.

@ax3l ax3l self-requested a review November 21, 2023 01:36
@ax3l ax3l self-assigned this Nov 21, 2023
@ax3l ax3l added the install label Nov 21, 2023
@ax3l ax3l added this to the 0.15.3 milestone Nov 21, 2023
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! 🚀 ✨

@ax3l ax3l enabled auto-merge (squash) November 21, 2023 01:39
@ax3l ax3l merged commit 72ab3d1 into openPMD:dev Nov 21, 2023
28 checks passed
@titoiride titoiride deleted the fix_cmake_warnings branch November 21, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake 3.27.1 generates warning when using FetchContent
2 participants