Draft: attribute_writing_ranks in HDf5 #1581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1592
to
+1733
| // std::cout << "Writing attribute " << parameters.name | ||
| // << ", filling it with value "; | ||
| // std::visit( | ||
| // [](auto const &val) { | ||
| // using T = | ||
| // std::remove_cv_t<std::remove_reference_t<decltype(val)>>; | ||
| // if constexpr ( | ||
| // !auxiliary::IsVector_v<T> && !auxiliary::IsArray_v<T>) | ||
| // { | ||
| // std::cout << val; | ||
| // } else | ||
| // { | ||
| // std::cout << "VECTOR/ARRAY"; | ||
| // } | ||
| // }, | ||
| // att.getResource()); | ||
| // std::cout << std::endl; |
Check notice
Code scanning / CodeQL
Commented-out code Note
franzpoeschel
force-pushed
the
hdf5-attribute-writing-ranks
branch
from
de36847 to
5086434
Compare
franzpoeschel
force-pushed
the
hdf5-attribute-writing-ranks
branch
from
5086434 to
86e5cc8
Compare
franzpoeschel
force-pushed
the
hdf5-attribute-writing-ranks
branch
from
86e5cc8 to
cc20b48
Compare
franzpoeschel
force-pushed
the
hdf5-attribute-writing-ranks
branch
from
cc20b48 to
df81453
Compare
franzpoeschel
force-pushed
the
hdf5-attribute-writing-ranks
branch
3 times, most recently
from
7222f20 to
d8ba9a2
Compare
New concept: global options with backend-specific implementation
franzpoeschel
force-pushed
the
hdf5-attribute-writing-ranks
branch
from
d8ba9a2 to
d04c16d
Compare
|
This does not work in the intended way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1542, this draft PR tries to implement that same feature for HDF5, too.
This is API-breaking, but only on the dev, since it turns
attribute_writing_ranksinto a global JSON option.The results are a bit weird, since there always seems to be one rank from which HDF5 takes the attribute definitions. In my tests, when running with 14 ranks, this is always rank 12; when running with 28 ranks, it's always rank 25. This might mean that the current approach will not work.