Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge yet] Fix: Read ParticlePatches Attr #1612

Closed
wants to merge 1 commit into from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 17, 2024

ParticlePatches are no openPMD records but a special group. It does not need required record components such as unitDimension.

Ref.: https://github.com/openPMD/openPMD-standard/blob/1.1.0/STANDARD.md#sub-group-for-each-particle-species

Fix #1609

Update: oh, but we write

If the particlePatches sub-group exists, the following records within it are required and the entries in each record are stored in a per particle patch order:

Action Items

I will probably to the latter.

`ParticlePatches` are no openPMD records but a special group.
It does not need required record components such as `unitDimension`.
@ax3l ax3l changed the title Fix: Read ParticlePatches Attr [Do not merge yet] Fix: Read ParticlePatches Attr Apr 17, 2024
@ax3l
Copy link
Member Author

ax3l commented Apr 17, 2024

@ax3l ax3l closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful Error Handling in Particle Patches
2 participants