Create arrays that represent the dimension of each grid axis #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
force-pushed
the
per_component_unitSI
branch
from
f713669 to
6cf7cfd
Compare
1 task
RemiLehe
changed the title
|
@RemiLehe can you please rebase? It collides with your previous whitespace changes :) |
ax3l
requested changes
Apr 24, 2018
openpmd_validator/check_h5.py
Outdated
| @@ -599,7 +599,7 @@ def check_meshes(f, iteration, v, extensionStates): | |||
| result_array += test_attr(field, v, "required", | |||
| "gridGlobalOffset", np.ndarray, [np.float32, np.float64]) | |||
| result_array += test_attr(field, v, "required", | |||
| "gridUnitSI", np.float64) | |||
| "gridUnitSI", np.ndarray, np.float64) | |||
There was a problem hiding this comment.
gridUnitDimension needs to be verified now as well
| rho.attrs["position"] = np.array([0.0, 0.0], dtype=np.float32) | ||
| rho.attrs["gridUnitSI"] = np.float64(1.0) | ||
| rho.attrs["gridUnitSI"] = np.array([1.0]*2, dtype=np.float64) |
There was a problem hiding this comment.
Wow, interesting syntax...
maybe we can write [1.0, 1.0] for clarity?
or define a variable named dataDim = 2 for 2 so it's not a magic number?
| rho.attrs["gridUnitSI"] = np.float64(1.0) | ||
| rho.attrs["gridUnitSI"] = np.array([1.0]*2, dtype=np.float64) | ||
| rho.attrs["gridUnitDimension"] = \ | ||
| np.array( [1.,0.,0.,0.,0.,0.,0.]*2, dtype=np.float64 ) |
There was a problem hiding this comment.
maybe add comment behind: # x: spatial (L), y: spatial (L)
| E.attrs["gridGlobalOffset"] = np.array([0.0, 0.0], dtype=np.float32) | ||
| E.attrs["gridUnitSI"] = np.float64(1.0) | ||
| E.attrs["gridGlobalOffset"] = np.array([0.0, 0.0], dtype=np.float32) | ||
| E.attrs["gridUnitSI"] = np.array([1.0]*3, dtype=np.float64 ) |
| E.attrs["gridGlobalOffset"] = np.array([0.0, 0.0], dtype=np.float32) | ||
| E.attrs["gridUnitSI"] = np.array([1.0]*3, dtype=np.float64 ) | ||
| E.attrs["gridUnitDimension"] = \ | ||
| np.array( [1.,0.,0.,0.,0.,0.,0.]*3, dtype=np.float64 ) |
RemiLehe
force-pushed
the
per_component_unitSI
branch
from
6cf7cfd to
5d297d5
Compare
ax3l
approved these changes
Apr 24, 2018
|
thank you so much! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the changes proposed in openPMD/openPMD-standard#193
See this PR for more details.