updating numpy + vtk functions #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding vc dep for windows
Adding compilers in host
Adding setuptools in host
trying vs2019 deps
revert
Trying with pip for windows
revert
removing setup.py build_ext step
preserve_egg_dir to false
Adding setuptools in host
Preserving egg because why not
|
Excellent. |
pradal
approved these changes
Oct 2, 2024
| - {{ PYTHON }} -m pip install . -vv | ||
|
|
||
| requirements: | ||
| host: | ||
| - python | ||
| - setuptools | ||
| - numpy | ||
| - scipy | ||
| - cython |
There was a problem hiding this comment.
If you completly remove cython, remove it from the deps too
There was a problem hiding this comment.
I do not think that we want to remove cython, as we want the two c extensions for acceleration !
There was a problem hiding this comment.
I misunderstood some commit. I was a little bit afraid...
|
The vtkmodules is included in the vtk package. As per the vtk documentation: The 'vtk.py' module is obsolete and is only provided for backwards compatibility. When you import vtk, this module actually provides you with the 'vtkmodules.all' module via some internal trickery: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I updated some of the imports of vtk modules which were outdated and also made some updates of numpy functions to be compatible with 2.0 and 1.x.
For the compatibility with numpy 2.0 we still need to wait for the skan package to be updated.
Also with @christian34 we investigated the problems we had with the CI and they are now fixed.