Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-17826: Fix metrics ports after deprecation of kube-rbac-proxy #61

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

akram
Copy link

@akram akram commented Jan 15, 2025

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Fix metrics ports after deprecation of kube-rbac-proxy

Which issue(s) this PR fixes:

Fixes RHOAIENG-17826

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2025

@akram: This pull request references RHOAIENG-17826 which is a valid jira issue.

In response to this:

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Fix metrics ports after deprecation of kube-rbac-proxy

Which issue(s) this PR fixes:

Fixes RHOAIENG-17826

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Jan 15, 2025
Copy link

openshift-ci bot commented Jan 15, 2025

@akram: The label(s) kind/regression cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Fix metrics ports after deprecation of kube-rbac-proxy

Which issue(s) this PR fixes:

Fixes RHOAIENG-17826

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2025

@akram: This pull request references RHOAIENG-17826 which is a valid jira issue.

In response to this:

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Fix metrics ports after deprecation of kube-rbac-proxy

Which issue(s) this PR fixes:

Fixes RHOAIENG-17826

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@akram
Copy link
Author

akram commented Jan 15, 2025

Copy link

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@akram
Copy link
Author

akram commented Jan 15, 2025

/assign sutaakar

@akram
Copy link
Author

akram commented Jan 20, 2025

/retest

@akram
Copy link
Author

akram commented Jan 20, 2025

/test images

@KPostOffice
Copy link

/retest

Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, KPostOffice, sutaakar, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KPostOffice,sutaakar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 679f239 into opendatahub-io:dev Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants