MR API patch error fix (#3411)

* api patch error fix * tests fix
opendatahub-io · Oct 31, 2024 · 40fa17e · 40fa17e
1 parent d1ee01b
commit 40fa17e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/modelRegistry/modelVersionDetails.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/modelRegistry/modelVersionDetails.cy.ts
@@ -415,6 +415,7 @@ describe('Model version details', () => {
       cy.wait('@updateModelFormat').then((interception) => {
         expect(interception.request.body).to.deep.equal({
           modelFormatName: 'UpdatedFormat',
+          artifactType: 'model-artifact',
         });
       });
     });
@@ -439,6 +440,7 @@ describe('Model version details', () => {
       cy.wait('@updateModelVersion').then((interception) => {
         expect(interception.request.body).to.deep.equal({
           modelFormatVersion: '2.0.0',
+          artifactType: 'model-artifact',
         });
       });
     });

diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetailsView.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetailsView.tsx
@@ -168,7 +168,11 @@ const ModelVersionDetailsView: React.FC<ModelVersionDetailsViewProps> = ({
             value={modelArtifact?.modelFormatName || ''}
             saveEditedValue={(value) =>
               apiState.api
-                .patchModelArtifact({}, { modelFormatName: value }, modelArtifact?.id || '')
+                .patchModelArtifact(
+                  {},
+                  { modelFormatName: value, artifactType: modelArtifact?.artifactType },
+                  modelArtifact?.id || '',
+                )
                 .then(() => {
                   refreshModelArtifacts();
                 })
@@ -183,7 +187,11 @@ const ModelVersionDetailsView: React.FC<ModelVersionDetailsViewProps> = ({
             isArchive={isArchiveVersion}
             saveEditedValue={(newVersion) =>
               apiState.api
-                .patchModelArtifact({}, { modelFormatVersion: newVersion }, modelArtifact?.id || '')
+                .patchModelArtifact(
+                  {},
+                  { modelFormatVersion: newVersion, artifactType: modelArtifact?.artifactType },
+                  modelArtifact?.id || '',
+                )
                 .then(() => {
                   refreshModelArtifacts();
                 })