Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of Patternfly to v6 #3038

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Jul 26, 2024

Working on Spike: RHOAIENG-9577

Steps:

Update package.json to latest v6 versions and update the overrides (manually)
<commit 1>

Run the package install
npm i

Run code mods
npx @patternfly/pf-codemods@latest frontend/src/ --v6

Fix Code mods fail causes (manually)
<commit 2>

Re-Run code mods

npx @patternfly/pf-codemods@latest frontend/src/ --v6

npx @patternfly/pf-codemods@latest frontend/src/ --v6 —fix
<commit 3>

Fix Remaining Code Mod Errors (manually)
<commit 4>

Fix Lint Errors
npm run test:fix
<commit 5>

Manually fix remaining Lint Errors (manually)
<commit 6>

Run class-name-updater

npx @patternfly/class-name-updater --v6 frontend/src/ --fix
<commit 7>

Build attempt
npm run build

Fix remaining build issues (manually)
<commit 8>

Replace “—pf-v6-global—spacer” with “—pf-t—global—spacer”
<commit 9>

Home page fix (manually)
<commit 10>

image

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 26, 2024
@openshift-ci openshift-ci bot requested review from lucferbux and mturley July 26, 2024 21:03
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Jul 26, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase PR needs to be rebased and removed needs-rebase PR needs to be rebased labels Aug 21, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jeff-phillips-18
Copy link
Contributor Author

/check-required-labels

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 83.65385% with 34 lines in your changes missing coverage. Please review.

Project coverage is 85.57%. Comparing base (793bdb7) to head (93a9bca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/app/HeaderTools.tsx 53.84% 6 Missing ⚠️
frontend/src/components/FilterToolbar.tsx 91.66% 2 Missing ⚠️
frontend/src/components/OdhExploreCard.tsx 33.33% 2 Missing ⚠️
...tent/configurePipelinesServer/PipelineDropdown.tsx 0.00% 2 Missing ⚠️
...pelinesDetails/pipeline/PipelineDetailsActions.tsx 50.00% 2 Missing ⚠️
...concepts/topology/customNodes/ArtifactTaskNode.tsx 50.00% 2 Missing ⚠️
...onnectionTypes/manage/ManageConnectionTypePage.tsx 77.77% 2 Missing ⚠️
...screens/RegisteredModels/RegisteredModelAuthor.tsx 0.00% 2 Missing ⚠️
...gRuntimes/CustomServingRuntimeAPIProtocolLabel.tsx 33.33% 2 Missing ⚠️
frontend/src/components/EmptyDetailsView.tsx 66.66% 1 Missing ⚠️
... and 11 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3038   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files        1371     1372    +1     
  Lines       31180    31211   +31     
  Branches     8727     8741   +14     
=======================================
+ Hits        26681    26708   +27     
- Misses       4499     4503    +4     
Files with missing lines Coverage Δ
frontend/src/app/AboutDialog.tsx 96.55% <100.00%> (+0.25%) ⬆️
frontend/src/app/App.tsx 90.00% <ø> (ø)
frontend/src/app/AppLauncher.tsx 69.44% <ø> (ø)
frontend/src/app/AppNotificationDrawer.tsx 21.73% <ø> (ø)
frontend/src/app/DevFeatureFlagsBanner.tsx 100.00% <ø> (ø)
frontend/src/app/Header.tsx 100.00% <100.00%> (ø)
frontend/src/app/NavSidebar.tsx 100.00% <ø> (ø)
frontend/src/app/ThemeContext.tsx 100.00% <100.00%> (ø)
frontend/src/components/BrandImage.tsx 93.33% <ø> (ø)
...d/src/components/DashboardDescriptionListGroup.tsx 100.00% <100.00%> (ø)
... and 238 more

... and 103 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 793bdb7...93a9bca. Read the comment docs.

@jeff-phillips-18 jeff-phillips-18 changed the title [WIP] Spike Effort: Update version of Patternfly to v6 Update version of Patternfly to v6 Dec 4, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Dec 4, 2024
@jeff-phillips-18 jeff-phillips-18 force-pushed the patternfly-v6 branch 2 times, most recently from d2cd364 to 3a0599c Compare December 5, 2024 14:33
@jeff-phillips-18 jeff-phillips-18 force-pushed the patternfly-v6 branch 2 times, most recently from 37c0219 to a415198 Compare December 5, 2024 21:14
@christianvogt
Copy link
Contributor

Tested many areas and while there's still some outstanding issues I have shared with @jeff-phillips-18 and PF team, I haven't run into any issues that would be considered a breaking issue.

@jenny-s51
Copy link
Contributor

Tested many areas throughout the UI as well and noted a few outstanding issues which we agreed to capture in the existing epic as a follow-up story. Overall looks fantastic, really great work here @jeff-phillips-18

@christianvogt
Copy link
Contributor

/lgtm
/approve

god speed ('-')7

Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4b8c2bf into opendatahub-io:main Dec 6, 2024
6 checks passed
ConorOM1 pushed a commit to ConorOM1/odh-dashboard that referenced this pull request Dec 12, 2024
* Update to Patternfly v6

* Fix some alignment issues in table rows
ConorOM1 pushed a commit to ConorOM1/odh-dashboard that referenced this pull request Dec 12, 2024
* Update to Patternfly v6

* Fix some alignment issues in table rows
ConorOM1 pushed a commit to ConorOM1/odh-dashboard that referenced this pull request Dec 12, 2024
* Update to Patternfly v6

* Fix some alignment issues in table rows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants