-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version of Patternfly to v6 #3038
Update version of Patternfly to v6 #3038
Conversation
bf985d7
to
dd0cb20
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
63f8185
to
43ba58e
Compare
/check-required-labels |
8b43b85
to
5a1288c
Compare
d2cd364
to
3a0599c
Compare
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelinesList.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelines.cy.ts
Outdated
Show resolved
Hide resolved
37c0219
to
a415198
Compare
Tested many areas and while there's still some outstanding issues I have shared with @jeff-phillips-18 and PF team, I haven't run into any issues that would be considered a breaking issue. |
e071c8d
to
2258a28
Compare
2258a28
to
93a9bca
Compare
Tested many areas throughout the UI as well and noted a few outstanding issues which we agreed to capture in the existing epic as a follow-up story. Overall looks fantastic, really great work here @jeff-phillips-18 |
/lgtm god speed ('-')7 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update to Patternfly v6 * Fix some alignment issues in table rows
* Update to Patternfly v6 * Fix some alignment issues in table rows
* Update to Patternfly v6 * Fix some alignment issues in table rows
Working on Spike: RHOAIENG-9577
Steps:
Update package.json to latest v6 versions and update the overrides (manually)
<commit 1>
Run the package install
npm i
Run code mods
npx @patternfly/pf-codemods@latest frontend/src/ --v6
Fix Code mods fail causes (manually)
<commit 2>
Re-Run code mods
npx @patternfly/pf-codemods@latest frontend/src/ --v6
npx @patternfly/pf-codemods@latest frontend/src/ --v6 —fix
<commit 3>
Fix Remaining Code Mod Errors (manually)
<commit 4>
Fix Lint Errors
npm run test:fix
<commit 5>
Manually fix remaining Lint Errors (manually)
<commit 6>
Run class-name-updater
npx @patternfly/class-name-updater --v6 frontend/src/ --fix
<commit 7>
Build attempt
npm run build
Fix remaining build issues (manually)
<commit 8>
Replace “—pf-v6-global—spacer” with “—pf-t—global—spacer”
<commit 9>
Home page fix (manually)
<commit 10>