update model serving compatibility for connection types

[christianvogt]

https://issues.redhat.com/browse/RHOAIENG-14813

Description

Connections:

Connection types:

How Has This Been Tested?

• Enable the connection types feature flag disableConnectionTypes
• As an admin, navigate to Settings -> Connection types
• Observe the preinstalled types show the correct model serving compatibility labels.
• Duplicate a preinstalled type or hand craft a new type with appropriate model serving fields with appropriate env var names (can use the dropdown to auto add matching types).
• Observe the alert indicates the compatible model serving types.
• Create a new project
• Go to the project details -> Data Connections tab (testing data connection compatibility
• Create a new data connection (include a value for the Bucket field)
• Go to the Connections tab
• Observe the new connection is compatible with s3 object storage
• Create a new connection of type URI or OCI or s3
• Observe the new connection is compatible with the respective type

Test Impact

Updated tests.

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

[codecov]

Codecov Report

Attention: Patch coverage is 92.30769% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.90%. Comparing base (1cd4f29) to head (da29525).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
frontend/src/concepts/connectionTypes/utils.ts	95.23%	2 Missing ⚠️
...jects/screens/detail/connections/useConnections.ts	0.00%	1 Missing ⚠️
frontend/src/utilities/useWatchConnectionTypes.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3417      +/-   ##
==========================================
+ Coverage   85.85%   85.90%   +0.04%     
==========================================
  Files        1338     1338              
  Lines       30267    30282      +15     
  Branches     8346     8345       -1     
==========================================
+ Hits        25987    26014      +27     
+ Misses       4280     4268      -12     

Files with missing lines	Coverage Δ
...rc/concepts/connectionTypes/CompatibilityLabel.tsx	100.00% <ø> (ø)
frontend/src/concepts/connectionTypes/types.ts	100.00% <ø> (ø)
.../pages/connectionTypes/ConnectionTypesTableRow.tsx	67.92% <100.00%> (-1.17%)	⬇️
frontend/src/pages/connectionTypes/columns.ts	46.15% <ø> (ø)
...onnectionTypes/manage/ManageConnectionTypePage.tsx	93.84% <100.00%> (-0.19%)	⬇️
...screens/detail/connections/ConnectionsTableRow.tsx	100.00% <100.00%> (+3.84%)	⬆️
...eens/detail/connections/connectionsTableColumns.ts	83.33% <ø> (ø)
...jects/screens/detail/connections/useConnections.ts	84.61% <0.00%> (-1.10%)	⬇️
frontend/src/utilities/useWatchConnectionTypes.tsx	90.00% <0.00%> (+20.76%)	⬆️
frontend/src/concepts/connectionTypes/utils.ts	90.32% <95.23%> (-0.38%)	⬇️

... and 11 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd4f29...da29525. Read the comment docs.

[emilys314]

So this will not show model serving compatibility for connections with aws env vars but not the type of s3 I believe?

[christianvogt]

Correct because the type makes it into the storage-config and is necessary for model serving to work.
That being said, if all env vars for s3 are populated then we would add the annotation on edit / save. Unless I missed a case.

[christianvogt]

/retest

[jeff-phillips-18]

Works well. LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment