-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit support for OCI model serving compatibility #3459
Remove explicit support for OCI model serving compatibility #3459
Conversation
44a7e9b
to
bcae032
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
=======================================
Coverage 85.66% 85.66%
=======================================
Files 1347 1347
Lines 30670 30669 -1
Branches 8550 8550
=======================================
Hits 26272 26272
+ Misses 4398 4397 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates LGTM @emilys314 ! Deleted the oci-compliant-registry-v1
configMap from the shared cluster as discussed since it was showing up in the connection types list by default. No longer showing in the connection types list as expected.
"Model serving compatible type" dropdown looks good too and no longer references OCI registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally against the ods-qe-psi-08 cluster. I temporarily scaled down the operator in order to delete the oci-compliant-registry-v1
configmap and verified that it is not an option in model serving or the connection types page.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jenny-s51, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
towards [RHOAIENG-14748] enable connection types feature
Description
After review and discussion from Jeff DeMoss, we decided to remove the OCI ootb connection type, because it's not fully supported yet. Many OCI model registries may require authentication, and requires additional kserve support before being usable (https://kserve.github.io/website/latest/modelserving/storage/oci/#enabling-modelcars)
How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main