Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DefaultTaskGroup custom icon to use BanIcon #3489

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Nov 19, 2024

https://issues.redhat.com/browse/RHOAIENG-14822

Description

Updated the DefaultTaskGroup to use BanIcon

Screenshot 2024-11-19 at 11 53 44 AM

How Has This Been Tested?

  • Run a pipeline with cancelled task
  • Check whether the ExclamationTriangleIcon is changed to BanIcon for cancelled task

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (fbeb889) to head (19fd3e1).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...src/concepts/topology/PipelineDefaultTaskGroup.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3489   +/-   ##
=======================================
  Coverage   85.37%   85.38%           
=======================================
  Files        1352     1352           
  Lines       30869    30951   +82     
  Branches     8616     8650   +34     
=======================================
+ Hits        26353    26426   +73     
- Misses       4516     4525    +9     
Files with missing lines Coverage Δ
...src/concepts/topology/PipelineDefaultTaskGroup.tsx 17.94% <0.00%> (-2.06%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbeb889...19fd3e1. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b5f39ca into opendatahub-io:main Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants