Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cypress pipeline test #3497

Merged

Conversation

FedeAlonso
Copy link
Contributor

Description

Fix Cypress pipeline test.

How Has This Been Tested?

Using a 2.16 RHOAI
image

Test Impact

Yes

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

@antowaddle
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (3ba248d) to head (36619bc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3497      +/-   ##
==========================================
- Coverage   85.24%   85.24%   -0.01%     
==========================================
  Files        1355     1355              
  Lines       31074    31074              
  Branches     8663     8663              
==========================================
- Hits        26489    26488       -1     
- Misses       4585     4586       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba248d...36619bc. Read the comment docs.

---- 🚨 Try these New Features:

@openshift-merge-bot openshift-merge-bot bot merged commit aa74ed9 into opendatahub-io:main Nov 20, 2024
6 checks passed
@FedeAlonso FedeAlonso deleted the fix/cypress_pipeline_test branch November 20, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants