Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-14757]: Implement wrapped column header styling in ConnectionTypes field table #3499

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jenny-s51
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-14757

Description

Before:
Screenshot 2024-11-20 at 12 08 57 PM

After:
Screenshot 2024-11-20 at 12 09 23 PM

How Has This Been Tested?

  1. Go to Connection Types -> "Create connection type"
  2. Add rows to fields table by adding section heading(s) or field(s).
  3. Resize window to smaller viewport and verify that table headers wrap instead of truncate.

Test Impact

N/A, no changes to functionality.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jenny-s51 jenny-s51 requested review from jeff-phillips-18 and removed request for alexcreasy and lucferbux November 20, 2024 17:16
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (3ba248d) to head (5783d8e).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
- Coverage   85.24%   85.23%   -0.01%     
==========================================
  Files        1355     1355              
  Lines       31074    31074              
  Branches     8663     8663              
==========================================
- Hits        26489    26487       -2     
- Misses       4585     4587       +2     
Files with missing lines Coverage Δ
...onTypes/manage/ManageConnectionTypeFieldsTable.tsx 48.33% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba248d...5783d8e. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d0f1760 into opendatahub-io:main Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants