Add model redeploying status

[emilys314]

Closes https://issues.redhat.com/browse/RHOAIENG-3409

Description

Makes the status a spinner after editing a model, popover message says "Redeploying".

Basically the status functions will prioritize looking at the target state, since that is more indicative of what is going on.
I'm not 100% on what the correct message is to display. But the special return case could be removed and then it would default to the state of the target i.e. "Loading".

How Has This Been Tested?

1. Deploy a model
2. Edit the model and change something (most things will reload it)
3. The status should change to loading (the polling may be slow to update it)

Test Impact

Jest unit tests could be added to the utils functions, but there aren't any so i didn't add any.

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

@vconzola

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[emilys314]

cc @alexcreasy @lucferbux

[vconzola]

@kaedward Would you please take a quick peek at this? I think it looks OK, but you might have a different suggestion for the popover message.

[christianvogt]

The jira issue mentions this:

When activeModelState is in a pending state we will show the spinner without a tooltip.

Seems to me the fallback message right now is always going to be Unknown ?

[christianvogt]

@emilys314 did you get a response yet on suggestion of the new text? If not, we can always do a followup to update the text if everything else is good to go with the PR.

Should add unit tests for this util function.

[emilys314]

No updates on the wording, i believe Katie is out until next week

Sure I'll add tests

[emilys314]

The jira issue mentions this:

When activeModelState is in a pending state we will show the spinner without a tooltip.

Seems to me the fallback message right now is always going to be Unknown ?

Yeah so the active vs target states don't seem to be well documented anywhere, but here are some tests from kserve

• https://github.com/search?q=repo%3Akserve%2Fkserve+ModelState&type=code
• https://github.com/kserve/kserve/blob/master/pkg/apis/serving/v1beta1/inference_service_status_test.go#L405

I don't think activeModelState can ever just be pending.

During initial deployment it would have activeModelState: '', targetModelState: Loading

The popover text will be hidden if the function returns "", it can do that now because it looks at activeModelState which becomes that commonly. But targetModelState is more up to date so this PR would make it happen less.

However there does seem merit to return an emptry string sometimes so I can make a small update by changing
const stateMessage = targetModelState || activeModelState || 'Unknown';
to
const stateMessage = (targetModelState || activeModelState) ?? 'Unknown';

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (6adeed2) to head (6eea5e6).
Report is 25 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3513      +/-   ##
==========================================
+ Coverage   85.24%   85.54%   +0.30%     
==========================================
  Files        1356     1342      -14     
  Lines       31075    31003      -72     
  Branches     8660     8663       +3     
==========================================
+ Hits        26490    26523      +33     
+ Misses       4585     4480     -105     

Files with missing lines	Coverage Δ
...lServing/screens/global/InferenceServiceStatus.tsx	85.71% <100.00%> (ø)
...ving/screens/global/useRouteForInferenceService.ts	100.00% <100.00%> (ø)
...end/src/pages/modelServing/screens/global/utils.ts	100.00% <100.00%> (ø)
...verModels/deployedModels/DeployedModelsGallery.tsx	90.56% <100.00%> (ø)

... and 110 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adeed2...6eea5e6. Read the comment docs.

[christianvogt]

/lgtm

[alexcreasy]

Not tested, but the code looks good - thanks Emily!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [alexcreasy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment