Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-291]: Update Mi/Gi Instance in NotebookServerDetails #3514

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jenny-s51
Copy link
Contributor

Per latest comment in https://issues.redhat.com/browse/RHOAIENG-291 cc @antowaddle

Description

Before:

Screenshot 2024-11-22 at 4 45 24 PM

After:
Screenshot 2024-11-22 at 4 44 37 PM

How Has This Been Tested?

  1. Applications -> Enabled
  2. Click "Launch Application".
  3. Start a notebook server.
  4. When notebook server is created, go to Notebook server control panel -> Notebook server details.
  5. Verify units are correct.

Test Impact

N/A, tests covered in #3338

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@emilys314
Copy link
Contributor

/lgtm

image

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6f134d2 into opendatahub-io:main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants