-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(15128): load and error state for modelArtifact on mr version detail #3515
feat(15128): load and error state for modelArtifact on mr version detail #3515
Conversation
f29e98a
to
6b40a7a
Compare
there was still some discussion on how this should look, but i am planning to be out next week and wanted to get something in |
04e400f
to
0db253c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3515 +/- ##
==========================================
- Coverage 85.57% 85.56% -0.02%
==========================================
Files 1372 1372
Lines 31211 31216 +5
Branches 8741 8744 +3
==========================================
- Hits 26710 26709 -1
- Misses 4501 4507 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
c5b8332
to
fc396c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I can see the loading state in MR version details page.. wondering whether we are doing the same for Model Details page 🤔 - that will require a different ticket I guess.. this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gitdallas
I wanted to double check and I think we're good on the model details page. It doesn't need to load any extra data, it just uses the |
/retest |
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
fc396c3
to
254369c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gitdallas
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ail (opendatahub-io#3515) Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
…ail (opendatahub-io#3515) Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
closes: https://issues.redhat.com/browse/RHOAIENG-15128
Description
add loading spinner and error for the loading of modelArtifacts on mr version details page.
show spinner on full page as the loading doesn't take long and determines some of the page format
show error in the model location area
How Has This Been Tested?
you can see the spinner briefly if you refresh the page. otherwise i was hard coding an error value to see that.
Test Impact
had to add an intercept to make sure the right side of mr version detail loads after selecting a different version #
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main