Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0 model replicas display text #3517

Conversation

emilys314
Copy link
Contributor

@emilys314 emilys314 commented Nov 25, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-384

Description

The initial data retrieve on the modal would skip 0 and default to 1 because it was a falsey check and not a nullish check.

I also saw on the model row details it would show "Unknown" for 0, so i did the same fix there.

changes

How Has This Been Tested?

  1. Edit an already deployed model (kserve and/or modelmesh)
  2. Set the replicas to 0 ("Number of model server replicas to deploy" field)
  3. Save
  4. The model row details should show "Model server replicas 0" instead of "Model server replicas Unknown"
  5. Edit the model again
  6. The "Number of model server replicas to deploy" field should display 0 instead of 1

Test Impact

Very minor change so no tests updated

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (f0b961c) to head (5785087).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3517      +/-   ##
==========================================
- Coverage   85.30%   85.29%   -0.02%     
==========================================
  Files        1354     1354              
  Lines       31085    31091       +6     
  Branches     8682     8684       +2     
==========================================
+ Hits        26517    26519       +2     
- Misses       4568     4572       +4     
Files with missing lines Coverage Δ
...rojects/ModelMeshSection/ServingRuntimeDetails.tsx 96.42% <100.00%> (ø)
...d/src/pages/modelServing/screens/projects/utils.ts 93.54% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b961c...5785087. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a08ad68 into opendatahub-io:main Nov 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants