Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up pipeline version runs and navigate everything to global pipeline runs #3527

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Nov 26, 2024

JIRA: RHOAIENG-15519

Description

This PR does the following things:

  1. Get rid of the runs routes under pipeline version context. All the pipeline version related view/create run/schedules are navigated to global pipeline runs context
  2. Clean up the code to read experiment from ExperimenContext instead of URL params to make it more reliable
  3. Make Cancel button on Create/Duplicate run/schedule page and manage runs page navigate one page back in the browser history instead of assigning a hard context path. In this way, it's more clear that "Cancel" means "Go back to where you were at"

How Has This Been Tested?

Make sure nothing is broken around the pipelines area

Test Impact

Change cypress tests to adapt to the new change. Change all the pipeline version context runs to the global context and make sure the tests pass.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.51%. Comparing base (6f134d2) to head (4875313).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...sDetails/pipelineRun/PipelineRunDetailsActions.tsx 46.15% 7 Missing ⚠️
...es/content/tables/pipelineRun/PipelineRunTable.tsx 80.00% 2 Missing ⚠️
...content/tables/pipelineRun/PipelineRunTableRow.tsx 77.77% 2 Missing ⚠️
.../global/experiments/compareRuns/ManageRunsPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3527      +/-   ##
==========================================
+ Coverage   85.38%   85.51%   +0.12%     
==========================================
  Files        1353     1342      -11     
  Lines       31129    30970     -159     
  Branches     8692     8643      -49     
==========================================
- Hits        26581    26484      -97     
+ Misses       4548     4486      -62     
Files with missing lines Coverage Δ
...pts/pipelines/apiHooks/usePipelineRecurringRuns.ts 100.00% <ø> (ø)
...src/concepts/pipelines/apiHooks/usePipelineRuns.ts 100.00% <ø> (ø)
...epts/pipelines/content/createRun/CreateRunPage.tsx 100.00% <ø> (ø)
...es/content/createRun/DuplicateRecurringRunPage.tsx 100.00% <ø> (ø)
...s/pipelines/content/createRun/DuplicateRunPage.tsx 100.00% <ø> (ø)
...c/concepts/pipelines/content/createRun/RunPage.tsx 100.00% <100.00%> (ø)
...epts/pipelines/content/createRun/RunPageFooter.tsx 84.00% <100.00%> (ø)
...ntent/createRun/contentSections/RunTypeSection.tsx 100.00% <100.00%> (ø)
...pelinesDetails/pipeline/PipelineDetailsActions.tsx 97.22% <100.00%> (-0.28%) ⬇️
...ecurringRun/PipelineRecurringRunDetailsActions.tsx 93.75% <100.00%> (+0.56%) ⬆️
... and 21 more

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f134d2...4875313. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works very well

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 09ccd93 into opendatahub-io:main Nov 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants