-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource icon updates #3533
Resource icon updates #3533
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3533 +/- ##
==========================================
- Coverage 85.56% 85.55% -0.01%
==========================================
Files 1342 1371 +29
Lines 31016 31190 +174
Branches 8675 8731 +56
==========================================
+ Hits 26538 26685 +147
- Misses 4478 4505 +27
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Thanks, Jeff. |
@tobiastal I've updated per your comments in the spreadsheet and updated the screenshots above. |
b7caff3
to
7a683f3
Compare
Thanks @jeff-phillips-18 , there's still a few updates needed- I added these in a new column(=Tal review for PR 4/12) in the spreadsheet for specific rows. |
433e647
to
61143c1
Compare
@tobiastal Thanks. I've fixed and updated the screenshots above. |
61143c1
to
feec707
Compare
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: tobiastal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes RHOAIENG-14747
Closes RHOAIENG-12299
Description
Update the icons for the various resources. Create icons for each resource icon to allow them to be sized and colored appropriately.
Update the icon usage as specified in this spreadsheet
How Has This Been Tested?
Navigate to the pages described in the spreadsheet
Validate the resource icon for each page / component
Test Impact
No impact to automated tests as these changes are purely visual.
Screen shots
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
Updated Project Selector:
Request review criteria:
/cc @tobiastal @simrandhaliw