Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource icon updates #3533

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Dec 2, 2024

Closes RHOAIENG-14747
Closes RHOAIENG-12299

Description

Update the icons for the various resources. Create icons for each resource icon to allow them to be sized and colored appropriately.

Update the icon usage as specified in this spreadsheet

How Has This Been Tested?

Navigate to the pages described in the spreadsheet
Validate the resource icon for each page / component

Test Impact

No impact to automated tests as these changes are purely visual.

Screen shots

1
image


2
image


3
image


4
image


5
image


6
image


7
image


8
image


9
image


10
image


11
image


12
image


13
image


14
image


15
image


16
image


17
image


18
image


19
image


20
image


21
image


22
image


23
image


24
image


25
image


26
image


27
image


28
image


29
image


30
image


31
image


32
image


33
image


34
image


35
image


36
image


Updated Project Selector:

image

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

/cc @tobiastal @simrandhaliw

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 95.50562% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.55%. Comparing base (e4bac88) to head (feec707).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/concepts/design/utils.ts 85.45% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3533      +/-   ##
==========================================
- Coverage   85.56%   85.55%   -0.01%     
==========================================
  Files        1342     1371      +29     
  Lines       31016    31190     +174     
  Branches     8675     8731      +56     
==========================================
+ Hits        26538    26685     +147     
- Misses       4478     4505      +27     
Files with missing lines Coverage Δ
frontend/src/concepts/design/HeaderIcon.tsx 100.00% <100.00%> (ø)
frontend/src/concepts/design/InfoGalleryItem.tsx 100.00% <100.00%> (ø)
frontend/src/concepts/design/TitleWithIcon.tsx 100.00% <ø> (ø)
frontend/src/concepts/design/TypedObjectIcon.tsx 98.01% <100.00%> (+33.31%) ⬆️
...rontend/src/images/icons/AcceleratorProfileIcon.ts 100.00% <100.00%> (ø)
frontend/src/images/icons/ArtifactIcon.ts 100.00% <100.00%> (ø)
frontend/src/images/icons/BuildIcon.ts 100.00% <100.00%> (ø)
frontend/src/images/icons/ClusterSettingsIcon.ts 100.00% <100.00%> (ø)
frontend/src/images/icons/ConfigurationIcon.ts 100.00% <100.00%> (ø)
frontend/src/images/icons/CreateAndTrainIcon.ts 100.00% <100.00%> (ø)
... and 53 more

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bac88...feec707. Read the comment docs.

@tobiastal
Copy link

Thanks, Jeff.
I reviewed and added some comments in a new column in the spreadsheet for specific rows.

@jeff-phillips-18
Copy link
Contributor Author

@tobiastal I've updated per your comments in the spreadsheet and updated the screenshots above.

@tobiastal
Copy link

Thanks @jeff-phillips-18 , there's still a few updates needed- I added these in a new column(=Tal review for PR 4/12) in the spreadsheet for specific rows.

@jeff-phillips-18 jeff-phillips-18 force-pushed the resource-icon-updates branch 2 times, most recently from 433e647 to 61143c1 Compare December 4, 2024 13:09
@jeff-phillips-18
Copy link
Contributor Author

@tobiastal Thanks. I've fixed and updated the screenshots above.

Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: tobiastal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6ac8b17 into opendatahub-io:main Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants