Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: Retry mechanism for e2e tests #3536

Conversation

FedeAlonso
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-16485

Description

Add a retry mechanism to the e2e Cypress tests.

How Has This Been Tested?

I've forced the failure of the application.cy.ts test here 9a1c676
Then I've ran the cypress job (cypress/job/cypress-tests/59)
In the report, 3 attempts are shown:
image

Then I've fixed the test here 8e55ff2
And ran the cypress job (cypress/job/cypress-tests/60)
And the test was up and running fine again
image

Test Impact

It's an "enhancement"

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@FedeAlonso FedeAlonso requested a review from lucferbux December 3, 2024 12:00
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (6a6600c) to head (bb0462f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3536      +/-   ##
==========================================
- Coverage   85.54%   85.54%   -0.01%     
==========================================
  Files        1342     1342              
  Lines       31016    31016              
  Branches     8675     8675              
==========================================
- Hits        26534    26533       -1     
- Misses       4482     4483       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6600c...bb0462f. Read the comment docs.

Co-authored-by: Christian Vogt <cvogt@redhat.com>
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e4bac88 into opendatahub-io:main Dec 3, 2024
4 checks passed
@FedeAlonso FedeAlonso deleted the RHOAIENG-16485/retry_mechanism_for_e2e_tests branch December 3, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants