-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kserve raw feature flag #3542
Add kserve raw feature flag #3542
Conversation
f327959
to
233da90
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3542 +/- ##
==========================================
- Coverage 85.54% 85.54% -0.01%
==========================================
Files 1342 1371 +29
Lines 31025 31191 +166
Branches 8679 8731 +52
==========================================
+ Hits 26541 26683 +142
- Misses 4484 4508 +24
... and 62 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -25,6 +25,7 @@ spec: | |||
disableKServe: false | |||
disableKServeAuth: false | |||
disableKServeMetrics: false | |||
disableKServeRaw: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be adding feature flags to our custom resource definition or config any more until it is ready for release.
The rest of the code can stay and you can toggle the feature flag using the dev feature flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I removed it, should i remove it from manifests/common/crd/odhdashboardconfigs.opendatahub.io.crd.yaml
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emilys314 good question. I'm inclined to say remove it.
The reason I say this is because in general there's potential for a feature flag to change over the course of development and we don't want to release a flag early that will change or give the customer an ability to disable and then when we do release the feature, they won't get the new default.
5e579b1
to
0e7c3fd
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-16488
Description
Adds
disableKServeRaw
feature flag. defaulted to true for nowHow Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main