Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kserve raw feature flag #3542

Conversation

emilys314
Copy link
Contributor

@emilys314 emilys314 commented Dec 4, 2024

https://issues.redhat.com/browse/RHOAIENG-16488

Description

Adds disableKServeRaw feature flag. defaulted to true for now

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@emilys314 emilys314 force-pushed the add-kserve-raw-feature-flag branch 2 times, most recently from f327959 to 233da90 Compare December 4, 2024 20:51
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (ca3d3e4) to head (0e7c3fd).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3542      +/-   ##
==========================================
- Coverage   85.54%   85.54%   -0.01%     
==========================================
  Files        1342     1371      +29     
  Lines       31025    31191     +166     
  Branches     8679     8731      +52     
==========================================
+ Hits        26541    26683     +142     
- Misses       4484     4508      +24     
Files with missing lines Coverage Δ
frontend/src/concepts/areas/const.ts 100.00% <ø> (ø)
frontend/src/concepts/areas/types.ts 100.00% <100.00%> (ø)
frontend/src/k8sTypes.ts 100.00% <ø> (ø)

... and 62 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3d3e4...0e7c3fd. Read the comment docs.

@@ -25,6 +25,7 @@ spec:
disableKServe: false
disableKServeAuth: false
disableKServeMetrics: false
disableKServeRaw: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be adding feature flags to our custom resource definition or config any more until it is ready for release.
The rest of the code can stay and you can toggle the feature flag using the dev feature flags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I removed it, should i remove it from manifests/common/crd/odhdashboardconfigs.opendatahub.io.crd.yaml as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilys314 good question. I'm inclined to say remove it.

The reason I say this is because in general there's potential for a feature flag to change over the course of development and we don't want to release a flag early that will change or give the customer an ability to disable and then when we do release the feature, they won't get the new default.

@emilys314 emilys314 force-pushed the add-kserve-raw-feature-flag branch 2 times, most recently from 5e579b1 to 0e7c3fd Compare December 5, 2024 16:03
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6a0979e into opendatahub-io:main Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants