Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Attempting to better log errors when failing to createrolebindings for MR permissions #3545

Closed

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Dec 4, 2024

Nothing to see here, just getting an image

… rolebindings for MR permissions

Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
@mturley
Copy link
Contributor Author

mturley commented Dec 4, 2024

/hold

@openshift-ci openshift-ci bot requested review from lucferbux and pnaik1 December 4, 2024 19:03
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mturley. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (e4bac88) to head (b9b790f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3545      +/-   ##
==========================================
- Coverage   85.56%   85.52%   -0.05%     
==========================================
  Files        1342     1342              
  Lines       31016    31025       +9     
  Branches     8675     8679       +4     
==========================================
- Hits        26538    26533       -5     
- Misses       4478     4492      +14     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bac88...b9b790f. Read the comment docs.

@mturley mturley closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold This PR is hold for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant